Skip to content

docs(docs): accept typed effect seam and plan rollout - #2201

Merged
justinhelmer merged 1 commit into
mainfrom
docs/accept-0074-typed-effects-plan
Sep 22, 2026
Merged

justinhelmer merged 1 commit into
mainfrom
docs/accept-0074-typed-effects-plan

Conversation

@coreplane-switchboard

Copy link
Copy Markdown
Contributor

Accepts decision record 0074 and adds an implementation-ready four-unit plan for runner-owned side effects. This gives push, rebase, GitHub writes and connectors one typed receipt boundary without granting child shells write authority.

Why: The record proposal passed its cold-reader gate, while #2197, #2196 and #2200 confirmed that effects the runner does not perform cannot be authoritative transition facts.

Where to look

  1. Accepted record status Promotes record 0074 from proposed to accepted; generated decision documentation follows this source.
  2. Acceptance re-evaluation Records the cold-reader and review gates, restates both halves of the bet, and adds the two post-proposal fixtures.
  3. Plan authority and rollout Sets four person-merged units, one-release shadowing, shared spec obligations and fail-closed stop conditions. ⚠ A loose stop condition could let implementation weaken an existing guard.
  4. Push product contract Makes exact-tree gates, runner receipts, directive-run publication and shell-route removal explicit U1 requirements. ⚠ This contract decides what may publish and what counts as ready.
  5. Remaining effect contracts Defines the shared rebase service, marker-reconciled GitHub writes and compile-time connector registry.
  6. U1 acceptance fixtures Binds the parser, exact-tree, readiness and directive open-PR cases to runnable proofs, including issue 2200.
  7. Cross-unit verification contract Names the bound proof and receipt-runnable predicate for the documentation change and each implementation unit.

Feedback wanted: Check that U1 fully covers directive and ship-parented coding runs, and that each unit's receipt predicate is concrete enough to become its contract.

Risk: Docs-only, but this plan governs four security-sensitive implementation PRs. A missing fence could preserve a rival write route; rollback is reverting this PR before implementation begins.

Verified: Passed decisions:check, docs:check, specs:check, hygiene:check, scoped Prettier and the PR-title gate; CI remains the full gate.

Decisions (3)
Validation (6 criteria)
Criterion Proof
Record status and accepted-body rules remain valid npm run decisions:check passed: 114 records valid; accepted-body amendment rules passed against origin/main.
Generated decision index reflects accepted record 0074 npm run docs:gen updated docs/explanation/design-decisions.md; npm run docs:check passed for all 12 generated sources.
Plan references valid spec and code/test paths npm run specs:check passed: 51 specs and 5680 proof references checked; every Code/Tests path exists.
Public documentation adds no unrecorded private imprint npm run hygiene:check passed: 9 files checked, existing allowed hits unchanged.
Changed documentation is formatted npx prettier --check on the decision, plan and generated index passed.
PR title follows repository release grammar npm run check:pr-title -- "docs(docs): accept typed effect seam and plan rollout" passed.
For agents

Branch rebased onto origin/main at 57a0e07 before push; pushed head is f75abf6. docs/explanation/design-decisions.md is generated by npm run docs:gen; review its status-row change but do not hand-edit it. No runtime code or tests changed.
Requested by @justinhelmer in slack:C0BRRHKFLCB

🤖 Generated with Claude Code

Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>

@coreplane-switchboard coreplane-switchboard Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: The acceptance amendment and implementation plan are internally consistent, preserve the decision-record history, and bind each rollout unit to concrete proofs.

Note

Approved · head f75abf6 · no findings

Full review

No findings; the acceptance amendment and implementation plan are consistent and ready to merge.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: coreplane-switchboard[bot] reviewed this PR and posted an LGTM verdict (see its review). This repository opted in through its REVIEW_BOT_LOGIN and REVIEW_BOT_ID variables.

@justinhelmer
justinhelmer merged commit 9f6516d into main Sep 22, 2026
30 checks passed
@justinhelmer
justinhelmer deleted the docs/accept-0074-typed-effects-plan branch September 22, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant