docs(docs): accept typed effect seam and plan rollout - #2201
Merged
Merged
Conversation
Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
coreplane-switchboard
Bot
requested a review
from justinhelmer
as a code owner
September 22, 2026 08:09
Contributor
Author
There was a problem hiding this comment.
LGTM: The acceptance amendment and implementation plan are internally consistent, preserve the decision-record history, and bind each rollout unit to concrete proofs.
Note
Approved · head f75abf6 · no findings
Full review
No findings; the acceptance amendment and implementation plan are consistent and ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts decision record 0074 and adds an implementation-ready four-unit plan for runner-owned side effects. This gives push, rebase, GitHub writes and connectors one typed receipt boundary without granting child shells write authority.
Why: The record proposal passed its cold-reader gate, while #2197, #2196 and #2200 confirmed that effects the runner does not perform cannot be authoritative transition facts.
Where to look
Feedback wanted: Check that U1 fully covers directive and ship-parented coding runs, and that each unit's receipt predicate is concrete enough to become its contract.
Risk: Docs-only, but this plan governs four security-sensitive implementation PRs. A missing fence could preserve a rival write route; rollback is reverting this PR before implementation begins.
Verified: Passed decisions:check, docs:check, specs:check, hygiene:check, scoped Prettier and the PR-title gate; CI remains the full gate.
Decisions (3)
Validation (6 criteria)
npm run decisions:checkpassed: 114 records valid; accepted-body amendment rules passed against origin/main.npm run docs:genupdated docs/explanation/design-decisions.md;npm run docs:checkpassed for all 12 generated sources.npm run specs:checkpassed: 51 specs and 5680 proof references checked; every Code/Tests path exists.npm run hygiene:checkpassed: 9 files checked, existing allowed hits unchanged.npx prettier --checkon the decision, plan and generated index passed.npm run check:pr-title -- "docs(docs): accept typed effect seam and plan rollout"passed.For agents
Branch rebased onto origin/main at 57a0e07 before push; pushed head is f75abf6. docs/explanation/design-decisions.md is generated by
npm run docs:gen; review its status-row change but do not hand-edit it. No runtime code or tests changed.Requested by @justinhelmer in slack:C0BRRHKFLCB
🤖 Generated with Claude Code