revert: "fix(core): keep recovery off the person's plate (#2168)"

[justinhelmer]

Mechanical revert of the squash merge b43af4a (#2168), one commit, no other change.

Why. A bot-only production deploy of main at 06:18Z uploaded the shim Worker — where the ship runner lives — at b43af4a while the container stayed on release 1.260.3 (9f64917); the only difference between the two is #2168. Since 06:27Z the runner reads every completed coding child as "ended before its work was ready for review" and aborts the unit (#2169, #2103, #2164 tonight). Reverting #2168 makes main equal the container's code, so a Worker redeploy from main removes the skew tonight. #2168 lands again by reverting this revert once release 1.260.4 moves both parts together.

Where to look. The single revert commit; nothing else.

Risk. Docs and message wording return to their 1.260.3 state until the re-land; no behaviour the container does not already have.

Verified. CI on this branch; after the Worker redeploy, a fresh ship unit whose child completes must end merge-ready.

Tracking: #2187 (the skew), #2141 (what #2168 fixed; re-lands with 1.260.4).

🤖 Generated with Claude Code

[coreplane-switchboard]

Changes requested: Three test regressions leave removed or changed recovery behavior without the required proof.

Warning

Changes requested · head ebff82f · 3 findings: 3 minor

Severity	Finding	Where
minor	F1 Test removed — src/userMessageCheck.test.ts: the test file	src/userMessageCheck.test.ts:1
minor	F2 Registry-read failure coverage was removed	src/channels/mcpConnectView.test.ts:134
minor	F3 The next-step assertion no longer verifies the next steps	src/mcp/connect.test.ts:84

Full review

F1 — Confidence: high. The guard reports exactly: test-guard: src/userMessageCheck.test.ts — removed: the test file — no spec covers it; add its spec in this PR or restore the test. Restore the test or explicitly license its removal through the covering spec.

F2 — Confidence: high. The test no longer makes openTicket() reject, so the changed failure() path can stop returning 503 or rendering the registry-unavailable response without detection. Restore the rejected-registry scenario and assert the new response.

F3 — Confidence: high. /link|user/ does not prove that any refusal names a usable next step; generic messages such as “link unavailable” would pass. Assert the new branch-specific guidance for not_authorizing, not_found, expired, and used. The remaining unlicensed test-guard checks are wording refactors with verification intact.

[coreplane-switchboard]

Changes requested: Two test regressions remain: an unlicensed test-file deletion and lost MCP registry-failure coverage.

Warning

Changes requested · head ebff82f · 2 findings: 2 minor

Severity	Finding	Where
minor	F1 Test removed — src/userMessageCheck.test.ts: the test file	src/userMessageCheck.test.ts:1
minor	F2 MCP registry failure path lost its 503 regression coverage	src/channels/mcpConnectView.test.ts:134

Full review

F1 (minor, high confidence): The required guard reports exactly: test-guard: src/userMessageCheck.test.ts — removed: the test file — no spec covers it; add its spec in this PR or restore the test. Restore the test or add an explicit spec change licensing its removal.

F2 (minor, high confidence): The test previously forced openTicket() to reject and verified the handler returned a sanitized 503 response. A regression that lets this rejection escape or changes the response is now invisible. Retain the scenario and update only its expected wording. The other unlicensed test-guard checks are wording refactors with equivalent behavioral assertions retained.

[justinhelmer]

Closing unmerged: release 1.260.4 (714dbd3) moved the shim Worker and the container together (release run 35698173058, deploy done 07:31Z, all Workers at 714dbd3), which ends the skew in #2187 without reverting #2168. Kept open as the fallback until the roll landed; Justin's call at 00:1x PDT.