Repository navigation
feat: automatically update the active CLI install - #127
Conversation
There was a problem hiding this comment.
No verdict submitted — not approving.
Reviewed at e21f050.
For agents
Full review
Review blocked by a preflight infrastructure failure: git rev-parse HEAD returned no completion receipt (metadata_unavailable), so I could not confirm the checkout matches e21f050a832cea98bf103cc735cc70a41ef7804d. I stopped without submitting findings or a verdict.
|
Warning Polylane could not verify the production impact of this pull request. No production resource runs or consumes this CLI: Also considered · 3 refuted
Analysed against 8 cloud accounts and 1 repository
Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to. Polylane analysed Did this help? React 👍 or 👎 so the next review is sharper. |
|
@claude review PR #127 at exact head e21f050 against REVIEW.md. Run the repo checks and clean build smoke, verify the PR claims, and post findings inline. Focus on active-install ownership, concurrent updates, version pins, and command output/result preservation. Do not edit, push, merge, or release. The Switchboard review stopped before source review because its mandatory checkout command returned metadata_unavailable. Node 20, 22, and 24 CI passed at this head. A local independent reviewer is also checking the same head; the parent owns all fixes. |
justinhelmer
left a comment
There was a problem hiding this comment.
LGTM: No Important issues found in the automatic updater at e21f050.
Independent Codex review. Read the full 11-file diff against base 917d99b, swept references for every changed function, checked PR-body behavior claims, and made a second adversarial pass over installation detection, version pins, concurrency, child execution, and command output/result preservation.
From a disposable detached checkout: npm ci, live codegen, typecheck, lint, and all 566 tests passed on Node 26.6.0. A clean-environment build and executable version smoke passed. All 16 updater and bundled-CLI tests also passed on Node 20, 22, and 24. Package-manager mutation remains fixture-based; no real global installation was changed. Real Homebrew formula/pin-list source and Bun's documented commands support the manager assumptions. Windows update behavior was read but not executed locally.
This is a COMMENT-state review under the authenticated human identity, not an author approval or a review-bot identity. Merge, release, deployment, and live update acceptance are separate.
There was a problem hiding this comment.
LGTM: no issues found
Reviewed at e21f050.
For agents
Rationale: No consequential source defects found at e21f050; requested local tests and clean-build smoke were not performed due to runtime restrictions.
Full review
No qualifying source findings; local typechecking was blocked by missing generated files, and this runtime prohibits the requested dependency installation, tests, and clean-build smoke.
polylane updatecurrently only prints commands, so installed CLIs stay stale until a user updates them manually. This change detects the active install and updates it without a prompt, either on demand or after a successful command at most once per day.npm, Bun, and Homebrew installs use the owning package manager. Standalone installs verify the release checksum and version before replacing the bundle. The current command keeps its original version and result; the next command uses the update. Update output stays on stderr. CI, development, unknown installs, automatic opt-outs, prerelease builds, and active version pins are preserved.
Validation at e21f050: