Skip to content

chore(codegen): drop the dead scan reports exclusion - #124

Merged
boristane merged 1 commit into
mainfrom
chore/drop-scan-reports-codegen-exclusion
Oct 6, 2026
Merged

boristane merged 1 commit into
mainfrom
chore/drop-scan-reports-codegen-exclusion

Conversation

@boristane

Copy link
Copy Markdown
Contributor

Removes the codegen exclusion for scan report endpoints and schemas. The API no longer serves them, so the exclusion is dead.

Why: #91 removed the scan command and excluded /scan_reports and the Scan Report schema from codegen while the spec still served them. The backend has since removed scan reports, and the live spec at https://api.polylane.com/v1/doc has neither.

Where to look

  1. The exclusion list now names only the retired automations feature.

Feedback wanted: none; a one-line cleanup.

Risk: If the spec served scan report paths again, codegen would generate client methods for them; no command calls them. Revert restores the exclusion.

Verified: npm run codegen (261 paths, 326 operations, none for scan reports or skills), npm run typecheck, npm run lint, npm run test (544/544) and npm run build all pass.

🤖 Generated with Claude Code

The live OpenAPI document no longer serves /v1/scan_reports or the Scan
Report schema, so the exclusion that kept them out of the generated client
matches nothing. The scan command, skill commands, and skills OAuth scopes
were already removed in #91, #95, and #98.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@polylane

polylane Bot commented Oct 6, 2026

Copy link
Copy Markdown

Warning

Polylane could not verify the production impact of this pull request.

Checked codegen/parse-spec.ts against the live spec at api.polylane.com/v1/doc: zero /scan_reports paths, no Scan Report schema, and no remaining reference to either in the repo. The change removes an exclusion, so it adds nothing new and drops nothing used.

View the full analysis →

Also considered · 2 refuted
  • Refuted · Removing the scan_reports exclusion regenerates dead client paths and schemas · The live OpenAPI document at the generator's production source carries zero /scan_reports paths and no 'Scan Report' schema (200 response, 0 grep matches), and the repo has no reference to either.
  • Refuted · A schema that references an excluded schema breaks when the exclusion is removed · Removing an exclusion only widens what is generated; the referenced-schema hazard runs the other direction (excluding a schema others reference) and is unaffected here.
Analysed against 7 cloud accounts and 1 repository
  • Cloud accounts: coreplane-prod, baseberry-uat, coreplane-infra, coreplane, coreplane-gtm, 251714435813, Polylane
  • Repository: coreplanelabs/cli

View in Polylane Disable reviews

Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to.

Connect resources

Polylane analysed 3114314 for production impact. You can ask follow-ups by mentioning @polylane in a comment.

Did this help? React 👍 or 👎 so the next review is sharper.

@coreplane-switchboard coreplane-switchboard Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Removing the obsolete scan-report exclusions preserves the automation exclusions and introduces no verified defects.

Note

Approved · head 3114314 · no findings

Full review

No actionable findings.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved: coreplane-switchboard[bot] reviewed this PR and posted an LGTM verdict (see its review). A repo admin enabled this via the auto-approve workflow.

@boristane
boristane merged commit 9fbaa05 into main Oct 6, 2026
6 checks passed
@boristane
boristane deleted the chore/drop-scan-reports-codegen-exclusion branch October 6, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants