Repository navigation
chore(codegen): drop the dead scan reports exclusion - #124
Merged
Merged
Conversation
The live OpenAPI document no longer serves /v1/scan_reports or the Scan Report schema, so the exclusion that kept them out of the generated client matches nothing. The scan command, skill commands, and skills OAuth scopes were already removed in #91, #95, and #98. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Polylane could not verify the production impact of this pull request. Checked Also considered · 2 refuted
Analysed against 7 cloud accounts and 1 repository
Polylane could not find the cloud resources this repository manages, so this review looked at the entire cloud account. Connect this repository to its resources and the next review will focus on exactly what this code deploys to. Polylane analysed Did this help? React 👍 or 👎 so the next review is sharper. |
matanyall
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the codegen exclusion for scan report endpoints and schemas. The API no longer serves them, so the exclusion is dead.
Why: #91 removed the
scancommand and excluded/scan_reportsand theScan Reportschema from codegen while the spec still served them. The backend has since removed scan reports, and the live spec at https://api.polylane.com/v1/doc has neither.Where to look
Feedback wanted: none; a one-line cleanup.
Risk: If the spec served scan report paths again, codegen would generate client methods for them; no command calls them. Revert restores the exclusion.
Verified:
npm run codegen(261 paths, 326 operations, none for scan reports or skills),npm run typecheck,npm run lint,npm run test(544/544) andnpm run buildall pass.🤖 Generated with Claude Code