Repository navigation
fix: compact Edit Object Types dialog with a larger table (v2.0) - #79
Merged
Merged
Conversation
The object table was capped at about three rows, the form used three group boxes of one label/field column each, and every validation shrank the dialog (adjustSize), clipping the form's labels after "Edit Selected". The table now takes the dialog's extra height (above a splitter), the form is one grid of three label/field pairs per row with the filament properties as its last row and the form actions next to its status, and the dialog keeps its size. The radius is labelled "Tube radius" for filaments, and the "Save & Close" button shows its ampersand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
uermel
pushed a commit
that referenced
this pull request
Oct 16, 2026
🤖 I have created a release *beep* *boop* --- ## [2.0.0-alpha.4](copick-shared-ui-v2.0.0-alpha.3...copick-shared-ui-v2.0.0-alpha.4) (2026-10-16) ### 🐞 Bug Fixes * compact Edit Object Types dialog with a larger table (v2.0) ([#79](#79)) ([2d56650](2d56650)) ### ⚙ Continuous Integration * v2.0 release PR titles without the branch scope ([#87](#87)) ([a6c4d7c](a6c4d7c)) --- Merging this PR will publish a copick-shared-ui alpha prerelease to PyPI. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the main-line fix to v2.0.
Fixes the layout of the shared Edit Object Types dialog, used by ChimeraX-copick ("✏️ Edit Object Types") and napari-copick ("✏️ Edit Objects").
Problems
adjustSize(), so "Edit Selected" (and each keystroke in Name) shrank the dialog to 800×654 and clipped the form's labels.Change
&&).All widget attributes and the constructor stay the same, so callers and tests are unaffected (64 passed on main, 103 on v2.0). Checked in ChimeraX 1.12: the dialog stays at 900×720 after Edit Selected, with all labels readable.
🤖 Generated with Claude Code