Skip to content

fix: duplicate filament sets, meshes and segmentations - #123

Merged
uermel merged 1 commit into
mainfrom
uermel/fix-duplicate
Oct 15, 2026
Merged

uermel merged 1 commit into
mainfrom
uermel/fix-duplicate

Conversation

@uermel

@uermel uermel commented Oct 9, 2026

Copy link
Copy Markdown
Member

The duplicate (📋) button on the object tables did nothing for:

  • filament sets: duplicateClicked was never connected and there was no handler;
  • meshes and segmentations: the handlers were # TODO stubs.

Change

  • A shared _duplicate_entity stores pending edits first, so the copy includes them, then copies the entry to the user / session chosen in the Duplicate dialog. It uses copick's copy_copick_objects.
  • A segmentation keeps its type (binary, multilabel, instance or panoptic) and voxel size.
  • The table is refreshed, and the copy is shown and marked active.
  • If the target already exists, a warning names it.
  • update_meshes_table() is added, mirroring the segmentations one.

Tested in ChimeraX 1.12 on a copy of the 10521 test project:

  • filament set: copied with all filaments, listed and shown;
  • a second copy to the same session is refused with a warning;
  • instance segmentation: copied, keeps its type and voxel size;
  • mesh: copied.

Unit tests and the CI lint steps pass on both lines.

🤖 Generated with Claude Code

The duplicate button did nothing for filaments (not connected), meshes and segmentations (empty handlers). All
three now copy the entry to the chosen user / session with copick's copy operation (segmentations keep their type
and voxel size), after storing pending edits, and show the copy; a target that already exists is reported.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@uermel
uermel merged commit 320871d into main Oct 15, 2026
1 check passed
uermel pushed a commit that referenced this pull request Oct 16, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.16.0](chimerax-copick-v1.15.1...chimerax-copick-v1.16.0)
(2026-10-16)


### ✨ Features

* colour filaments by object, and filament transparency
([#125](#125))
([f401453](f401453))


### 🐞 Bug Fixes

* duplicate filament sets, meshes and segmentations
([#123](#123))
([320871d](320871d))
* require copick-shared-ui 0.8.1
([#131](#131))
([cc4ef81](cc4ef81))


### ⚙ Continuous Integration

* run the conventional-commits check at v6.41.3
([#130](#130))
([b1567a2](b1567a2))

---
Merging this PR will release ChimeraX-Copick on GitHub.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant