Repository navigation
fix: decode whole-number JSON literals as Float64 values - #12
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json_to_convex()rejects Pythonintvalues even though they are part of itsJsonValueinput type. Whole-number JSON literals therefore raiseValueError, including when nested in a successfulConvexHttpClientresponse.Decode untagged integer literals as Float64 values, matching Convex's JSON number representation. Keep the existing boolean branch first and preserve the separate tagged
$integer→ConvexInt64behavior. This also accepts exactly representable Float64 values above 2^53 on decode; it does not change outgoing Python integer coercion rules.Adds 18 offline regression/control cases: scalar and nested integer literals, all three public HTTP methods with real Requests JSON decoding, booleans, other primitives, and tagged Int64. Requests are intercepted before network I/O.
Validation:
pytest tests python/convex python/_convex).git diff --checkpass.no-any-returnfindings inpython/convex/__init__.py, reproduced with the original decoder.No live deployment was called. The WebSocket client's Rust conversion path is unchanged.