Skip to content

Update isAuthenticated to read from the session - #760

Merged
dowski merged 1 commit into
rebootfrom
dowski/auth-state-server
Oct 28, 2026
Merged

dowski merged 1 commit into
rebootfrom
dowski/auth-state-server

Conversation

@dowski

@dowski dowski commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Now code that observes the authenticated state is session based rather than returning true if the JWT identifies a user.

@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
auth-v2 Ready Ready Preview Oct 28, 2026 2:05pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
convex-auth-docs Ignored Ignored Oct 28, 2026 2:05pm UTC

Request Review

dowski commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator Author

@dowski
dowski force-pushed the dowski/auth-state-server branch from c251843 to b9adb4c Compare October 20, 2026 15:33
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from fb4748f to ebf9d14 Compare October 20, 2026 15:33
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from ebf9d14 to 86e0b19 Compare October 20, 2026 15:46
@dowski
dowski force-pushed the dowski/auth-state-server branch from b9adb4c to 584af24 Compare October 20, 2026 15:46
@dowski
dowski force-pushed the dowski/auth-state-server branch from 584af24 to caf47c7 Compare October 20, 2026 16:19
@dowski dowski changed the title Add a session-backed authState query to the core Add a sessionState query to the core Oct 20, 2026
@dowski dowski changed the title Add a sessionState query to the core Add a sessionState query and getSession helper Oct 20, 2026
@dowski
dowski force-pushed the dowski/auth-state-server branch from caf47c7 to 6638742 Compare October 21, 2026 14:16
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from 86e0b19 to 1053d64 Compare October 21, 2026 14:16
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from 1053d64 to 3f34310 Compare October 21, 2026 14:23
@dowski
dowski force-pushed the dowski/auth-state-server branch from 6638742 to 09a7584 Compare October 21, 2026 14:23
@dowski
dowski force-pushed the dowski/auth-state-server branch from 09a7584 to f7ba3a5 Compare October 21, 2026 16:39
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from 3f34310 to ff30c70 Compare October 21, 2026 16:39
@dowski
dowski force-pushed the dowski/auth-state-server branch from f7ba3a5 to e6411e9 Compare October 21, 2026 19:50
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from ff30c70 to 2f66a76 Compare October 21, 2026 19:50
@pkg-pr-new

pkg-pr-new Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@convex-dev/auth@760

commit: 0ccb472

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

Re-trigger cubic

@dowski
dowski force-pushed the dowski/auth-state-server branch from 183849b to 484d4d8 Compare October 26, 2026 23:27
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from fcde1bf to 201b3bd Compare October 26, 2026 23:27
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from 201b3bd to 957d13b Compare October 26, 2026 23:44
@dowski
dowski force-pushed the dowski/auth-state-server branch from 484d4d8 to 55613a7 Compare October 26, 2026 23:44
@dowski
dowski force-pushed the dowski/revoke-session-handle branch 2 times, most recently from 520e0ba to 2a03112 Compare October 26, 2026 23:50
@dowski
dowski force-pushed the dowski/auth-state-server branch from 55613a7 to c951ae8 Compare October 26, 2026 23:50
@dowski
dowski force-pushed the dowski/revoke-session-handle branch from 2a03112 to adf014c Compare October 27, 2026 14:51
@dowski
dowski force-pushed the dowski/auth-state-server branch from c951ae8 to 0c52fd4 Compare October 27, 2026 14:51
@dowski
dowski changed the base branch from dowski/revoke-session-handle to graphite-base/760 October 27, 2026 15:00
@dowski
dowski force-pushed the dowski/auth-state-server branch from 0c52fd4 to 18e3159 Compare October 27, 2026 15:00
@dowski
dowski force-pushed the graphite-base/760 branch from adf014c to 09915cc Compare October 27, 2026 15:00
@cursor
cursor Bot changed the base branch from graphite-base/760 to reboot October 27, 2026 15:01
@dowski
dowski force-pushed the dowski/auth-state-server branch from 18e3159 to e86f46c Compare October 27, 2026 15:01
@dowski
dowski force-pushed the dowski/auth-state-server branch from e86f46c to e3d65ba Compare October 27, 2026 21:49
@dowski
dowski requested a review from Nicolapps October 27, 2026 21:52

@Nicolapps Nicolapps left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks!

The core's `isAuthenticated` query now answers through `getAuthUserId`, so
it is `true` only while the access token's session (its subject) exists,
not merely while the token verifies. A subscriber re-runs the moment the
session is deleted, so revocation is observable before the token expires,
and the SSR cookie check becomes revocation-aware too.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dowski
dowski force-pushed the dowski/auth-state-server branch from e3d65ba to 0ccb472 Compare October 28, 2026 14:05
@dowski
dowski merged commit 9bde747 into reboot Oct 28, 2026
10 checks passed

This branch was successfully deployed

1 active deployment
Preview – auth-v2 — 0ccb472c Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants