feat: add streaming option during project creation#160
Conversation
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
There was a problem hiding this comment.
Pull request overview
Adds an optional --enable-streaming-response boolean flag to the launch command so users can opt into streaming responses when creating a new project. When the flag is omitted (and the chosen framework supports server commands), the CLI prompts the user interactively. The selected value is forwarded to the importProject mutation for both GitHub and FileUpload adapters.
Changes:
- New
--enable-streaming-responseflag and matching usage example added toLaunchcommand. github.ts/file-upload.tsadapters now read the flag, prompt when undefined (only inside the server-command-supported branch), and includeisStreamingEnabledin the import-project mutation variables.- Adds
isStreamingEnabled?: booleanto theConfigTypeand adds unit tests covering the prompt, flag-provided, and unsupported-framework branches for both adapters.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/commands/launch/index.ts | Registers the new enable-streaming-response boolean flag and adds a usage example. |
| src/adapters/github.ts | Destructures the new flag, prompts when undefined, stores on this.config, and sends isStreamingEnabled in the GraphQL mutation. |
| src/adapters/file-upload.ts | Mirrors the GitHub adapter changes for the file-upload flow. |
| src/types/launch.ts | Adds optional isStreamingEnabled to ConfigType. |
| src/adapters/github.test.ts | Tests for prompting, flag-provided, and unsupported-framework cases. |
| src/adapters/file-upload.test.ts | Same set of tests for the FileUpload adapter. |
Comments suppressed due to low confidence (1)
src/adapters/github.ts:244
- Minor: the prompt message "Enable Streaming Responses" reads as a statement rather than a question. For a
confirm-type prompt, phrasing it as a question (e.g. "Enable streaming responses?") would be clearer and consistent with typical inquirer prompt wording.
message: 'Enable Streaming Responses',
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
naeem-shakh-cs
left a comment
There was a problem hiding this comment.
is it getting merged directly to main?
f56b639
4bb7a6a to
f56b639
Compare
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
f56b639 to
526dc74
Compare
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
526dc74 to
61855f8
Compare
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
4b1401e
61855f8 to
4b1401e
Compare
4b1401e to
a1a01a9
Compare
🔒 Security Scan Results
⏱️ SLA Breach Summary
✅ BUILD PASSED - All security checks passed |
No description provided.