Bump NVIDIA Container Toolkit to 1.19.1#1810
Conversation
NVIDIA Container Toolkit 1.19.1 requires Go >= 1.25 and introduces various
format changes in mount options[1].
The new mounts options now include rbind and rprivate options, provoking an
error when the mount command gets those options and a --rbind flag. A new
mountExt helper function is added and a minimal adapter mountBind is preserved
to avoid breaking compat with existing calls.
[1] NVIDIA Container Toolkit commit d0103aa
NVIDIA/nvidia-container-toolkit@d0103aa
Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
angiglesias
force-pushed
the
bump-nvidia-ctk-to-1.19.x
branch
from
cfc5415 to
b044c63
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25.0, upgrades several dependencies (including NVIDIA container toolkit and CDI libraries), and refactors the mounting logic in initContainer.go by introducing a more flexible mountExt function. A critical bug was identified in the refactored mountBind function, where splitting an empty flags string results in an invalid empty option being passed to the mount command, which would fail container initialization. A suggestion has been provided to handle empty flags safely.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
1 participant
Newer drivers (r560 or later) are expected to work with the new impletmentation of the EGL external platform library egl-wayland2. Newer releases of the Nvidia Container Toolkit include support out of the box to generate CDIs including the egl-wayland2 library.
NVIDIA Container Toolkit 1.19.1 requires Go >= 1.25 and introduces various format changes in mount options[1].
The new mounts options now include rbind and rprivate options, provoking an error when the mount command gets those options and a --rbind flag. A new mountExt helper function is added and a minimal adapter mountBind is preserved to avoid breaking compat with existing calls.
[1] NVIDIA Container Toolkit commit d0103aa
NVIDIA/nvidia-container-toolkit@d0103aa