cmd/create: add --volume option to allow mounting host directories#1809
Open
isiin wants to merge 2 commits into
Open
cmd/create: add --volume option to allow mounting host directories#1809isiin wants to merge 2 commits into
isiin wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for custom volumes in Toolbx containers via a new --volume flag on the create command. It updates the CLI flags, container creation logic, documentation, and adds a system test. The feedback suggests using StringArrayVar instead of StringArrayVarP for the --volume flag since it does not have a shorthand character, which aligns better with the codebase's existing style.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+108
to
+112
| flags.StringArrayVarP(&createFlags.volume, | ||
| "volume", | ||
| "", | ||
| []string{}, | ||
| "Bind mount a volume into the Toolbx container") |
There was a problem hiding this comment.
Since the --volume flag does not have a shorthand character, it is more idiomatic and consistent with the rest of the file (such as the --authfile flag on line 79) to use StringArrayVar instead of StringArrayVarP with an empty shorthand string.
flags.StringArrayVar(&createFlags.volume,
"volume",
[]string{},
"Bind mount a volume into the Toolbx container")References
- Prioritize consistency with the existing code style over minor refactorings like inlining variables, especially when the current pattern is used throughout the codebase.
isiin
force-pushed
the
feature/add-custom-volumes
branch
from
1ee3486 to
8479421
Compare
Allow mounting host directories into Toolbx containers. This option provides a way to integrate specialized host-side environments (such as Nix or custom developer toolchains) without sacrificing the container's integrity or modifying shell configuration files. Fixes: containers#1600 - cmd/create: Add --volume option to 'toolbox create' - doc/toolbox.create.1.md: Update man page to document the new option and provide usage guidance and safety warnings. - system/101-create.bats: Add a test for create with --volume option Signed-off-by: isiin <isiin@abeam.ocn.ne.jp> containers#1809
isiin
added a commit
to isiin/toolbox
that referenced
this pull request
Jun 24, 2026
Per feedback on code style consistency, I have introduced '-V' as the shorthand for '--volume'. This justifies the use of StringArrayVarP and improves user experience by providing a consistent CLI interface. Signed-off-by: isiin <isiin@abeam.ocn.ne.jp> containers#1809
isiin
force-pushed
the
feature/add-custom-volumes
branch
from
8479421 to
0b1c2df
Compare
isiin
added a commit
to isiin/toolbox
that referenced
this pull request
Jun 24, 2026
Per feedback on code style consistency, I have introduced '-V' as the shorthand for '--volume'. This justifies the use of StringArrayVarP and improves user experience by providing a consistent CLI interface. Signed-off-by: isiin <isiin@abeam.ocn.ne.jp> containers#1809
isiin
force-pushed
the
feature/add-custom-volumes
branch
from
0b1c2df to
9225c80
Compare
isiin
added a commit
to isiin/toolbox
that referenced
this pull request
Jun 24, 2026
Per feedback on code style consistency, I have introduced '-V' as the shorthand for '--volume'. This justifies the use of StringArrayVarP and improves user experience by providing a consistent CLI interface. Signed-off-by: isiin <isiin@abeam.ocn.ne.jp> containers#1809
isiin
force-pushed
the
feature/add-custom-volumes
branch
from
9225c80 to
0155b8f
Compare
isiin
added a commit
to isiin/toolbox
that referenced
this pull request
Jun 24, 2026
Per feedback on code style consistency, I have introduced '-V' as the shorthand for '--volume'. This justifies the use of StringArrayVarP and improves user experience by providing a consistent CLI interface. Signed-off-by: isiin <isiin@abeam.ocn.ne.jp> containers#1809
isiin
force-pushed
the
feature/add-custom-volumes
branch
from
0155b8f to
11e858e
Compare
Per feedback on code style consistency, I have introduced '-V' as the shorthand for '--volume'. This justifies the use of StringArrayVarP and improves user experience by providing a consistent CLI interface. Signed-off-by: isiin <isiin@abeam.ocn.ne.jp> containers#1809
isiin
force-pushed
the
feature/add-custom-volumes
branch
from
11e858e to
497eda3
Compare
Author
|
recheck |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow mounting host directories into Toolbx containers. This option provides
a way to integrate specialized host-side environments (such as Nix or custom developer toolchains) without sacrificing the container's integrity or modifying shell configuration files.
Fixes: #1600
provide usage guidance and safety warnings.