feat(functions): add storage-confirm-upload function#69
Open
theothersideofgod wants to merge 10 commits into
Open
feat(functions): add storage-confirm-upload function#69theothersideofgod wants to merge 10 commits into
theothersideofgod wants to merge 10 commits into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
2 tasks
Handles deferred upload confirmation via HeadObject check. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add minio service for local S3 testing - Fix db-setup image (was pointing to wrong image) - Add S3/MinIO environment variables - Update API configuration for tenant support Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
theothersideofgod
force-pushed
the
feat/storage-confirm-upload
branch
from
b45414b to
dbdb3d4
Compare
- Change template from node-graphql to node-sql for connection pooling - Add pool and withUserContext support to mock-context helper Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Query metaschema_modules_public.storage_module for schema/table names - Use QuoteUtils.quoteQualifiedIdentifier for SQL identifier quoting - Remove string manipulation for schema derivation - Use connection pool from context instead of manual PgClient - Standardize env vars (CDN_ENDPOINT, AWS_ACCESS_KEY, AWS_REGION) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Mock storage_module query responses - Use pool mock instead of pg.Client mock - Add tests for storage_module lookup and schema validation - Test bucket resolution using storage_module schema names Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
theothersideofgod
force-pushed
the
feat/storage-confirm-upload
branch
from
9b3c461 to
8d37364
Compare
- Fix @pgsql/quotes version to ^17.1.0 (was incorrectly ^0.0.4) - Update lockfile to match node-sql template dependencies Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add CDN_ENDPOINT, S3_ENDPOINT, and AWS credentials to sharedEnv so storage-confirm-upload and other S3-dependent functions work in local dev mode (make dev-fn). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage-confirm-uploadfunction for deferred upload confirmation via HeadObject checkChanges
functions/storage-confirm-upload/- new functiondocker-compose.yml- add minio, fix images, update configskaffold.yaml- add profile for storage-confirm-uploadTest plan
🤖 Generated with Claude Code