Skip to content

Tell CodeRabbit not to check keyDates asOf against bsky.app #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sparkyfen merged 2 commits into from
Sep 21, 2026
+13 −0
Merged

Tell CodeRabbit not to check keyDates asOf against bsky.app #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3d805
Tell CodeRabbit not to check keyDates asOf against bsky.app
sparkyfen Sep 21, 2026
e250984
Name the nested keyDates shape in the asOf instruction
sparkyfen Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .coderabbit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,16 @@ reviews:
auto_review:
# 0 disables the pause and reviews every commit.
auto_pause_after_reviewed_commits: 0

# Stop the repeat false positive on keyDates asOf. A bsky.app page publishes
# the AppView's indexedAt as its article:published_time and datePublished, so
# a reviewer that opens the source URL sees a timestamp that differs from the
# record's createdAt and reports the asOf value as wrong. Saved learnings did
# not stop it, because a learning applies to similar code segments rather than
# as a general rule.
path_instructions:
- path: "*.json"
instructions: |
Every `asOf` field nested under `keyDates` (for example `keyDates.registration.opens.asOf`) is the source Bluesky post's `record.createdAt`, copied verbatim by the keydates worker.
Do not check `asOf` against a bsky.app page, a web search result, or MCP tool output. The bsky.app HTML (`article:published_time`, `datePublished`) exposes the AppView's `indexedAt`, not `createdAt`. `indexedAt` can be later or earlier than `createdAt`.
Only `record.createdAt` from `app.bsky.feed.getPosts` on public.api.bsky.app is authoritative. If you have not read that field, do not comment on `asOf`. A difference between `asOf` and any other timestamp is not a finding.
Loading