Repository navigation
fix(ui): dim every overlay from one shared scrim - #468
Merged
Merged
Conversation
The content shell faded its scrim from `settled`, a one-frame lag held by a 16ms timer. Opening an overlay started that timer and the entrance timer on the same frame, so the settle timer never re-armed: `phase` reached "shown" while `settled` stayed "starting", the scrim stayed transparent, and the panel slid in over an undimmed window. Replace the per-overlay scrim with `components/display/scrim.slint`, which owns the one dim level, and `globals/overlay-shadow.slint`, which asks for only the band of the topmost open overlay. An overlay opened over another therefore takes the dim over instead of layering a second, darker one, and no overlay's fade depends on its own animation state machine. The palette mounts above the title bar and dims the whole window like a dialog; the dialog keeps its own scrim, drawn above all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.