Skip to content

fix(remix): make checkbox styles value-comparable - #124

Open
leoafarias wants to merge 1 commit into
mainfrom
fix/121
Open

fix(remix): make checkbox styles value-comparable#124
leoafarias wants to merge 1 commit into
mainfrom
fix/121

Conversation

@leoafarias

Copy link
Copy Markdown
Member

Description

CheckboxStyler.onIndeterminate allocated a new identity-based
ContextVariant on every call, causing equivalent fortalCheckboxStyle()
results to compare unequal.

Reuse one shared indeterminate variant while preserving its predicate and
resolved styling behavior. Add regression coverage for equality and matching
hash codes.

Related Issues

Closes #121

Validation

  • fvm dart analyze
  • fvm dart run melos run ci
    • Generated artifacts reproduced byte-for-byte.
    • Documentation and Fortal parity checks passed.
    • 2,553 Remix, 275 Fortal, and 25 dashboard tests passed.

Checklist

  • My PR includes unit or integration tests for all changed behavior.
  • Existing documentation remains accurate; no documentation changes are required.
  • I am prepared to follow up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CheckboxStyler is not value-comparable: onIndeterminate allocates a fresh ContextVariant per call

1 participant