Conversation
SAY-5
force-pushed
the
fix/services-race-852
branch
from
May 2, 2026 06:21
8649a1b to
ba98d65
Compare
Author
|
Still relevant. The race in WithServicesTransform is unchanged on main, and #852 was closed by the stale bot rather than fixed. |
Closes compose-spec#852. Concurrent collector goroutine writing newProject.Services raced with the dispatch loop reading it. Signed-off-by: SAY-5 <say.apm35@gmail.com>
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
SAY-5
force-pushed
the
fix/services-race-852
branch
from
August 16, 2026 09:44
ce9241c to
70ee31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #852. Collector goroutine wrote
newProject.Serviceswhile the dispatch loop read it. Use a local map and assign aftereg.Wait().