Repository navigation
deploy: the health validation accepts the testConnection switch exactly when testConnection is routed - #3322
Merged
Merged
Conversation
…ly when testConnection is routed The deploy's health check expected no handler switches unless the version route was selected, so a box serving testConnection from Rust, which needs POLIS_API_CONNECTION_READS=1, failed validation. The check now expects that switch exactly when testConnection is in RUST_API_ROUTES, alongside the existing version rule. Every other check is unchanged. New cases cover the switch enabled, missing, unexpected and combined with other routes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…x and the 2.43.0 version landed on edge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
Contributor
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/validate_service.shchecks, after a deploy, that the Rust API's enabled handler switches match the routes nginx sends to it. It expected no switches at all unlessversionwas routed.testConnectionis served by Rust only withPOLIS_API_CONNECTION_READS=1, so a deploy that routestestConnectionwould fail validation even when the box is healthy.The check now expects
POLIS_API_CONNECTION_READSexactly whentestConnectionis inRUST_API_ROUTES, next to the existingversionrule. Every other check (version, identity, pools) is unchanged.Behaviour
pca2alone: unchanged, passes with no switches.testConnectionrouted with its switch: passes (failed before).testConnectionrouted without its switch, or the switch enabled without the route, or any other switch present: fails.Tests
python3 -m unittest discover -s scripts/tests -p test_api_health.py -v: 3 tests, 39 subcases pass; seven new subcases fail against the previous script.testConnection.🤖 Generated with Claude Code
https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx