Repository navigation
retire: the dormant API routes, the unused dependencies and settings - #3295
Merged
Merged
Conversation
…helpers, old bundles and embed demos Remove GET /share/<id>, /summary/<id>, /explore/<id>, /ot/<id>, /iip/:conversation_id and /iim/:conversation_id. Each has no successful request since July 7 in the access-log check through October 26. Remove /embed, /embedPreprod, /embedReport, /embedReportPreprod and their .html files, plus /styleguide and /dist/admin_bundle.js. The preproduction and report demos, styleguide and old admin bundle have no successful request since July 7. /embed had five 200 responses in the July 7 to October 26 window; the check did not record their latest timestamp. /embed.html had requests in that window; its last successful timestamp was not recorded separately. Remove /__webpack_hmr, /cached/*, GET and ALL /font/*, and the old /*embed*js/* proxy registration. The hot-reload endpoint had two 200 responses during the final 30 days of that window; the check did not record their latest timestamp. The other three paths have no successful request since July 7. Remove the unreachable catch-all proxy registration and the never-enabled missing-file branch, which had no calls. Remove the six corresponding Rust routing switches, nginx templates, link handlers, dedicated pools, counters, contracts and conformance cases. Drop their process settings and the legacy one-time-link router entry. Move the nineteen registrations to the retired inventory and verify the retired pages and demo filenames return 404 through the remaining proxy. Keep feeds, famous votes, site-id integrations, the live embed.js, conversation pages, home, privacy, terms, donate, signin, signout, report bundles and styles, all six topic moderation routes, and every table and column. The participation path gains no work, locks or waits. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
Remove users/invite, snapshot, metrics, sendEmailExportReady, math/correlationMatrix, mathUpdate, contributors, auth/deregister, dataExport, dataExport/results and math/pca. These paths had no successful request since July 7 in the retained access logs. Remove notifyTeam, whose last successful call was September 21. Remove dummyButton, which had two successful calls during September 26 through October 26; the access-log summary does not record their exact timestamps. Remove the matching CLI operations and documentation, the legacy button and metrics callers, report correlation fetching, and the Rust legacyPca handler, contract and routing switch. Mark all thirteen routes retired in the characterization inventory and replace their cases with a shared 404 test. Unknown API GETs return 404 without going to the static-file proxy. Remove aws-sdk v2 and the unused Mailgun, nodemailer, oauth, simple-oauth2, request, googleapis, aiplatform, vertexai, mimelib, nan and p3p direct packages and their unused type packages. Remove the periodic export test, comment-language backfill and inactive PCA polling loop, together with WEBSERVER_USERNAME, WEBSERVER_PASS, RUN_PERIODIC_EXPORT_TESTS, ADMIN_EMAIL_DATA_EXPORT_TEST, BACKFILL_COMMENT_LANG_DETECTION and the unused Mailgun settings. Keep axios, dd-trace and ENCRYPTION_PASSWORD_00001 because they still have readers. Feeds, famous votes, site-id integration, live pages, report assets, topic moderation, database tables and columns stay in place. Votes, comments and next-statement handling gain no new work or locks. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…roxy's 502 where no file server runs Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…on and refresh leaves Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
The recordings guard requires the route inventory, its scope and its cases to change in a separate pull request from the code they describe; those updates follow once this merges. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
The recordings guard requires the route inventory, its scope and its cases to change in a separate pull request from the code they describe; those updates follow once this merges. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
The recordings guard now treats the inventory and scope as the census they are, so the retired entries, scope and cases return to this change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
The recordings guard now treats the inventory and scope as the census they are, so the retired entries, scope and cases return to this change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…le settings go with the next re-record Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…de the shortened page lists
… the key custody fields Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…ired operations Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…e retired legacy pca switch Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
… with the next re-record Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…switches out; health count follows
…port gone with edge, health count follows
…ges landed first; retirements re-applied over them Content-only resolution: every removal this branch makes still happens, nothing a merged change removed comes back, the inventory lists each retired route once, the nginx map and the Rust route table carry the union.
…ages, self-hosting and share-bundle changes landed first; the dormant API retirements re-applied over them Content-only resolution: every removal this branch makes still happens, nothing a merged change removed comes back, the inventory lists each of the 63 retired identities once with the shared 404 test, the nginx map and the Rust route table carry the union, and the health census is 118 fields.
…the deterministic vote safety tests landed on edge; the retirements kept, health census recounted
…e deterministic vote safety tests landed on edge; the retirements kept, health census recounted
…hange landed on edge; retirements kept, health census recounted
…le retirement orphaned Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx
…nge landed on edge; retirements kept, health census recounted
…landed first; the share-bundle retirement re-applied over it Content-only resolution: the link-page and conversation-page code this branch removes stays removed, the participant statement list route checks edge added stay, the inventory lists each retired route once, and the health census is 124 fields.
…articipant statement list and the share-bundle retirement landed first; the dormant API retirement re-applied over them Content-only resolution: every retired route stays retired, edge's additions stay, the inventory lists the 63 retired identities once with the shared 404 test, and the health census is 122 fields.
…d on edge; the dormant API retirement kept, health census 122
Contributor
Delphi Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove users/invite, snapshot, metrics, sendEmailExportReady,
math/correlationMatrix, mathUpdate, contributors, auth/deregister,
dataExport, dataExport/results and math/pca. These paths had no successful
request since July 7 in the retained access logs.
Remove notifyTeam, whose last successful call was September 21. Remove
dummyButton, which had two successful calls during September 26 through
October 26; the access-log summary does not record their exact timestamps.
Remove the matching CLI operations and documentation, the legacy button
and metrics callers, report correlation fetching, and the Rust legacyPca
handler, contract and routing switch. Mark all thirteen routes retired in
the characterization inventory and replace their cases with a shared 404
test. Unknown API GETs return 404 without going to the static-file proxy.
Remove aws-sdk v2 and the unused Mailgun, nodemailer, oauth, simple-oauth2,
request, googleapis, aiplatform, vertexai, mimelib, nan and p3p direct
packages and their unused type packages. Remove the periodic export test,
comment-language backfill and inactive PCA polling loop, together with
WEBSERVER_USERNAME, WEBSERVER_PASS, RUN_PERIODIC_EXPORT_TESTS,
ADMIN_EMAIL_DATA_EXPORT_TEST, BACKFILL_COMMENT_LANG_DETECTION and the
unused Mailgun settings.
Keep axios, dd-trace and ENCRYPTION_PASSWORD_00001 because they still have
readers. Feeds, famous votes, site-id integration, live pages, report
assets, topic moderation, database tables and columns stay in place.
Votes, comments and next-statement handling gain no new work or locks.
Dependencies removed from server/package.json: @google-cloud/aiplatform, @google-cloud/vertexai, aws-sdk (v2), googleapis, mimelib, nan, nodemailer, nodemailer-mailgun-transport, oauth, p3p, request, simple-oauth2 and their type packages; each verified unreferenced before removal. The exact hosted CI command passed: 2,386 server tests; Rust fmt, clippy and tests green.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ss9NfEMZS9Qm4FZ2npXDrx