Skip to content

Shield pct start and the template check from a closed console - #239

Open
MickLesk wants to merge 3 commits into
mainfrom
fix/hangup-start-and-template
Open

MickLesk wants to merge 3 commits into
mainfrom
fix/hangup-start-and-template

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

a closed console sends SIGHUP to every process in the foreground group.
The run survives it since #219, but pct start and the pveam list | grep template check did not: in three days 10 runs reported "would not start" for a container that came up, and 5 "not available after download" for a template on disk.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

A closed console sends SIGHUP to every process in the foreground group.
The run survives it since #219, but pct start and the pveam list | grep
template check did not: in three days 10 runs reported "would not
start" for a container that came up, and 5 "not available after
download" for a template on disk.
Inside a command substitution the engine's HUP trap is already reset,
so that subshell died of the hangup and returned 129 for a command that
had finished. update-apps runs vzdump this way: ten backups since the
shield landed ran to their notification and were still reported as
"Backup failed", and the update stopped. In a subshell that does not
catch HUP itself, ignore it there too.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/hangup-start-and-template \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

This PR touches pve/, so it needs a Proxmox VE host.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/hangup-start-and-template/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/hangup-start-and-template

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant