Repository navigation
Conversation
A closed console sends SIGHUP to every process in the foreground group. The run survives it since #219, but pct start and the pveam list | grep template check did not: in three days 10 runs reported "would not start" for a container that came up, and 5 "not available after download" for a template on disk.
Inside a command substitution the engine's HUP trap is already reset, so that subshell died of the hangup and returned 129 for a command that had finished. update-apps runs vzdump this way: ten backups since the shield landed ran to their notification and were still reported as "Backup failed", and the update stopped. In a subshell that does not catch HUP itself, ignore it there too.
Contributor
Try this branchThe engine and the scripts resolve independently, so a production script can Swap This PR touches Run a script from a fork as wellNote that Useful flags while testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
a closed console sends SIGHUP to every process in the foreground group.
The run survives it since #219, but pct start and the pveam list | grep template check did not: in three days 10 runs reported "would not start" for a container that came up, and 5 "not available after download" for a template on disk.
🔗 Related Issue
Fixes #
✅ Prerequisites (X in brackets)
API.txtwas updated to match.🛠️ Type of Change (X in brackets)
README,docs/,CONTRIBUTING.md, or other docs.🤖 AI Assistance (X in brackets)