Skip to content

Say what the host sees when a container gets no address - #230

Open
MickLesk wants to merge 1 commit into
mainfrom
fix/no-ip-facts
Open

MickLesk wants to merge 1 commit into
mainfrom
fix/no-ip-facts

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

"No IP assigned after 60 attempts" was all the log held: 225 failures in a week, 7.5 % of all, with nothing to tell a missing DHCP server from a bridge without an uplink. The failure now logs the configured address and VLAN, the state of eth0, whether the bridge exists and has an uplink port, and for DHCP that no server answered. The MAC address is left out.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

"No IP assigned after 60 attempts" was all the log held: 225 failures in
a week, 7.5 % of all, with nothing to tell a missing DHCP server from a
bridge without an uplink. The failure now logs the configured address
and VLAN, the state of eth0, whether the bridge exists and has an
uplink port, and for DHCP that no server answered. The MAC address is
left out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant