Skip to content

core: drop the SUDO_ variables an update through sudo carries - #229

Merged
michelroegl-brunner merged 1 commit into
mainfrom
fix/sudo-env
Nov 11, 2026
Merged

michelroegl-brunner merged 1 commit into
mainfrom
fix/sudo-env

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

pnpm 12 refuses global commands while SUDO_USER is set, which failed the Immich update for anyone running sudo update (community-scripts/ProxmoxVE#18607). Nothing reads these variables, and apart from them root via sudo looks exactly like a root login.

🔗 Related Issue

Fixes community-scripts/ProxmoxVE#18607

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

pnpm 12 refuses global commands while SUDO_USER is set, which failed the
Immich update for anyone running sudo update (VE #18607). Nothing reads
these variables, and apart from them root via sudo looks exactly like a
root login.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/sudo-env \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/sudo-env/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/sudo-env

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@michelroegl-brunner
michelroegl-brunner merged commit 39ac453 into main Nov 11, 2026
4 checks passed
@github-actions
github-actions Bot deleted the fix/sudo-env branch November 12, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Immich update to 3.4.0 fails on PNPM

2 participants