Skip to content

feat: let setup_deb822_repo use a keyring already on the system - #227

Merged
MickLesk merged 1 commit into
mainfrom
fix/deb822-local-keyring
Nov 11, 2026
Merged

MickLesk merged 1 commit into
mainfrom
fix/deb822-local-keyring

Conversation

@MickLesk

Copy link
Copy Markdown
Member

✍️ Description

The key argument now also takes a path. A keyring that ships with the system -- Debian's archive keyring for backports -- is referenced in Signed-By where it is, without a download or a copy into /etc/apt/keyrings. A path that does not exist fails with 252.

curl_with_retry runs its DNS pre-check for http(s) URLs only. For a file:// URL the hostname pattern matched nothing, so the lookup ran on the whole URL and failed with 6 before curl was called. That is what broke the Gotenberg v9 install, which passed its backports keyring as file:///usr/share/keyrings/debian-archive-keyring.gpg.

🔗 Related Issue

Fixes #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected (Proxmox VE and/or Incus, as applicable).
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.
  • API.txt regenerated – If a function signature or behavior changed, API.txt was updated to match.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • ✨ New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing behavior in a way that may require updates in every downstream script.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, docs/, CONTRIBUTING.md, or other docs.

🤖 AI Assistance (X in brackets)

If you used an AI tool (GitHub Copilot, Claude, ChatGPT, etc.) to write or generate any code in this PR, you must confirm compliance below.
Select exactly one option.

  • No AI used – Code was written without AI assistance.
  • AI was used – The output has been reviewed and corrected, and I take responsibility for it matching this repo's conventions.

The key argument now also takes a path. A keyring that ships with the
system -- Debian's archive keyring for backports -- is referenced in
Signed-By where it is, without a download or a copy into
/etc/apt/keyrings. A path that does not exist fails with 252.

curl_with_retry runs its DNS pre-check for http(s) URLs only. For a
file:// URL the hostname pattern matched nothing, so the lookup ran on
the whole URL and failed with 6 before curl was called. That is what
broke the Gotenberg v9 install, which passed its backports keyring as
file:///usr/share/keyrings/debian-archive-keyring.gpg.
@github-actions

Copy link
Copy Markdown
Contributor

Try this branch

The engine and the scripts resolve independently, so a production script can
be run against the engine from this PR by setting one variable:

COMMUNITY_SCRIPTS_CORE_URL=https://raw.githubusercontent.com/community-scripts/core/fix/deb822-local-keyring \
bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/debian.sh)"

Swap ct/debian.sh for whatever exercises the change.

Run a script from a fork as well
curl -fsSL https://raw.githubusercontent.com/community-scripts/core/fix/deb822-local-keyring/tools/run.sh |
  bash -s -- https://raw.githubusercontent.com/YOU/DevScripts/your-branch ct/debian.sh \
             https://raw.githubusercontent.com/community-scripts/core/fix/deb822-local-keyring

Note that run.sh is reached through a pipe, so the script it starts inherits
an exhausted stdin. Whiptail is fine — it opens /dev/tty — but a plain read
would see EOF. The single-variable form above does not have that problem.

Useful flags while testing

dev_mode=net logs every engine fetch with status and duration, which is the
quickest way to confirm the branch is really being used. dev_mode=keep stops a
failed build from deleting the container along with the evidence.

@MickLesk
MickLesk merged commit 452bd48 into main Nov 11, 2026
5 checks passed
@github-actions
github-actions Bot deleted the fix/deb822-local-keyring branch November 11, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant