Skip to content

spi: prioritize TX completion #2423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adeebshihadeh wants to merge 1 commit into from
+10 −4
Closed

spi: prioritize TX completion #2423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions board/drivers/interrupts.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ void init_interrupts(bool check_rate_limit){

for(uint16_t i=0U; i<NUM_INTERRUPTS; i++){
interrupts[i].handler = unused_interrupt_handler;
NVIC_SetPriority((IRQn_Type)i, 1U);
}

// Init interrupt timer for a 1s interval
Expand Down
5 changes: 3 additions & 2 deletions board/drivers/spi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,10 @@ void spi_rx_done(void) {
spi_state = SPI_STATE_HEADER_NACK;
response_len = 1U;
}
llspi_miso_dma(spi_buf_tx, response_len);

__disable_irq();
spi_state = next_rx_state;
llspi_miso_dma(spi_buf_tx, response_len);
__enable_irq();
if (!checksum_valid) {
spi_error_count += 1U;
}
Expand Down
3 changes: 3 additions & 0 deletions board/stm32h7/llspi.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ void llspi_init(void) {
REGISTER_INTERRUPT(DMA2_Stream2_IRQn, DMA2_Stream2_IRQ_Handler, SPI_IRQ_RATE, FAULT_INTERRUPT_RATE_SPI_DMA)
REGISTER_INTERRUPT(DMA2_Stream3_IRQn, DMA2_Stream3_IRQ_Handler, SPI_IRQ_RATE, FAULT_INTERRUPT_RATE_SPI_DMA)

NVIC_SetPriority(SPI4_IRQn, 0U);
NVIC_SetPriority(DMA2_Stream3_IRQn, 0U);

// Setup MOSI DMA
register_set(&(DMAMUX1_Channel10->CCR), 83U, 0xFFFFFFFFU);
register_set(&(DMA2_Stream2->CR), (DMA_SxCR_MINC | DMA_SxCR_TCIE), 0x1E077EFEU);
Expand Down
1 change: 1 addition & 0 deletions board/sys/critical.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ static volatile bool interrupts_enabled = false;

void enable_interrupts(void) {
interrupts_enabled = true;
__set_BASEPRI(0U);
__enable_irq();
}

Expand Down
4 changes: 2 additions & 2 deletions board/sys/sys.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ extern uint8_t global_critical_depth;

#ifndef ENTER_CRITICAL
#define ENTER_CRITICAL() \
__disable_irq(); \
__set_BASEPRI(1U << (8U - __NVIC_PRIO_BITS)); \
global_critical_depth += 1U;
#endif

#ifndef EXIT_CRITICAL
#define EXIT_CRITICAL() \
global_critical_depth -= 1U; \
if ((global_critical_depth == 0U) && interrupts_enabled) { \
__enable_irq(); \
__set_BASEPRI(0U); \
}
#endif

Expand Down
Loading