Repository navigation
fix(desktop): Windows payload limit fits the fork's natives and compile cache - #30
Merged
Merged
Conversation
…le cache Fork release run 41320584358 failed: upstream's server compile cache (pingdotgg#28572) adds 14 files on a native Windows build, taking the fork's payload from 68 to 82 files over the limit of 80. Upstream cross-builds Windows, so it skips the cache and validates 53 files. Raise the limit to 110, keeping upstream's headroom of about 27 files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork releaserun 41320584358 failed on the Windows build:Windows packaged payload contains 82 files; expected at most 80.Cause: upstream pingdotgg#28572 (nightly v0.1.7-nightly.20261101.4035) writes
resources/server-compile-cache/in anafterPackhook that only runs when the build host matches the target. The fork builds on a native Windows runner, so the hook ran and took the payload from 68 files (run 41278363282) to 82. Upstream's Windows x64 build loggedSkipping unexecutable target win32/x64and validated 53 files, so its limit of 80 never counted the cache.Fix: raise
WINDOWS_PACKAGED_PAYLOAD_FILE_LIMITfrom 80 to 110, which keeps upstream's headroom of about 27 files. The cache stays in the build and is still counted. The nightly merge itself succeeded in that run, so this PR does not merge upstream.Verification:
check:changedpasses format, lint, knip, typecheck and react compiler. Its test step fails locally on Windows on 8 tests inbuild-desktop-artifact.test.tsand 13 inClaudeAdapterV2.test.ts; the same counts fail without this change. Not checked before merge: the real Windows build, which theFork releaserun after this merge proves.🤖 Generated with Claude Code (Claude Opus 5.5, T3 Code)