The review accounts for MCP entries - #18
Merged
Merged
Conversation
The manifest carries MCP servers as names and sanitized URLs, so the review screen's leaves-the-machine claim was incomplete without them: the drawing's 'mcp servers recorded by name' line is restored. The accounting splits across two lines so real server names cannot truncate the excluded-items tail off an 80-column terminal. MCPs stay out of the picker on purpose: there is nothing to consent to at export — the consent moment is the receiving machine's per-server prompt.
◈ PR Lens
Architecture 2 components touched across 3 lanes. Data flow No data-flow sequence changed in this PR. View
Tip The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change. 🪧 More tips
Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest's MCP entries (names + sanitized URLs) leave the machine, so the review screen's leaves-the-machine accounting was incomplete without them. Restored as a
mcp servers recorded by nameline, split across two accounting lines so long names can't truncate the tail at 80 columns. MCPs stay out of the picker by design: there is nothing to consent to at export — consent happens on the applying machine per server. Rendering only; 180 tests green.