Skip to content

The review accounts for MCP entries - #18

Merged
ohansFavour merged 1 commit into
mainfrom
feat/review-mcp-accounting
Sep 17, 2026
Merged

ohansFavour merged 1 commit into
mainfrom
feat/review-mcp-accounting

Conversation

@ohansFavour

@ohansFavour ohansFavour commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

The manifest's MCP entries (names + sanitized URLs) leave the machine, so the review screen's leaves-the-machine accounting was incomplete without them. Restored as a mcp servers recorded by name line, split across two accounting lines so long names can't truncate the tail at 80 columns. MCPs stay out of the picker by design: there is nothing to consent to at export — consent happens on the applying machine per server. Rendering only; 180 tests green.

The manifest carries MCP servers as names and sanitized URLs, so the
review screen's leaves-the-machine claim was incomplete without them:
the drawing's 'mcp servers recorded by name' line is restored. The
accounting splits across two lines so real server names cannot truncate
the excluded-items tail off an 80-column terminal. MCPs stay out of the
picker on purpose: there is nothing to consent to at export — the
consent moment is the receiving machine's per-server prompt.
@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~2 changed · 🔴 -0 removed · 0 flows · 2 files · commit dfc1fff


Architecture

Architecture diagram for coldteadotai/agent-sync at dfc1fff

2 components touched across 3 lanes.

Open the interactive canvas


Data flow

No data-flow sequence changed in this PR.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail

Tip

The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change.

🪧 More tips
  • Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists.
  • Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds.
  • Click the link under each diagram to open it on a canvas you can zoom, pan and step through.
  • Open a diagram on the canvas, then press W or click play to walk through the change one step at a time.
  • The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time.
  • Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs on every push.
  • Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works.
  • Push a commit and the comment redraws for the new head. A slow older run never overwrites a newer one.
  • Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion.

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

@ohansFavour
ohansFavour merged commit f2c9842 into main Sep 17, 2026
4 checks passed
@ohansFavour
ohansFavour deleted the feat/review-mcp-accounting branch September 17, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant