Repository navigation
Drop a claimed task whose stored payload cannot be read - #90
Merged
Merged
Conversation
`_reap_task` deserialized the stored payload before it decided the fate of the task. A payload with a task function, a retry callback, or a status the code base does not know raised on every pass. The claim script had already renewed the lease, so the task stayed in the running set and the same error repeated every `CLAIM_TTL`. - Drop a claimed task whose payload cannot be read any more: log the read error with its traceback, and delete the stored payload. The running entry stays, so a lease holder's late acknowledge still writes its result, and the reaper script sweeps the entry once the hash is gone. - Document the behavior in the README. Fix #73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reaper read the stored payload before deciding the fate of a task, so a payload the code can no longer read, a task function or retry callback that is gone, or a status a newer release wrote, raised on every pass. The claim script had already renewed the lease, so the task stayed in the running set and the same error repeated every
CLAIM_TTL, and the inspector could not clear it.Fixes #73