Repository navigation
Hardcode decode_responses=True on Redis clients - #88
Merged
Merged
Conversation
The backend now loads both the sync and async Redis clients with decode_responses=True, so task IDs, lease fields, and pub/sub payloads arrive as strings. Drop the bytes decoding at every call site and the bytes handling in the tests. Document the inverted decision in CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The backend previously assumed redis-py's default
decode_responses=Falseand decoded every value at the call site. This inverts that decision: both the sync and async Redis clients now load withdecode_responses=True, so task IDs, lease fields, and pub/sub payloads are strings straight from the client.decode_responses=True.decode()handling in the broker, peek, result, and telemetry paths