Repository navigation
Assume decode_responses=False and fail loudly - #85
Merged
Merged
Conversation
Redis connections always use the redis-py default decode_responses=False, so drop the isinstance bytes/str fallbacks. The reaper no longer swallows unreadable payloads: misconfiguration and Redis data altered mid-flight fail loudly instead of being handled defensively. Document both design decisions in CONTRIBUTING.md and require a persistent Redis without eviction in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis connections use the redis-py default
decode_responses=False, yet the backend guarded against decoded responses withisinstance(..., bytes)fallbacks, and the reaper swallowed unreadable payloads. Those guards hid misconfiguration and altered data instead of surfacing them.decode_responses=Falsefor all Redis connections and drop the bytes/str fallbacks in the reaper, peeker, and telemetry loop.> [!IMPORTANT]one-liner to the README.