Skip to content

The task hash stores a queue_name field that no reader uses #79

Description

@codingjoe

Found while reviewing PR #69 with the SuperJoe crew. Filed as out-of-scope there.

RedisTaskBackend.enqueue() stores queue_name in the task hash. No reader uses it. The acquire and mover scripts read data and score. The reaper only makes sure that the hash exists. Every reader takes the queue from task.queue_name in the payload or from the key that holds the id. The backend writes this field on each enqueue, but no code reads it.

Remove the field, or make one reader use it. Then the payload does not need to carry the queue name as well.

Reference: threadmill/backends/redis.py, the enqueue hash mapping.

Activity

  1. added
    bloatOver-engineering and dead code
    yeetDelete it: dead code, unused flexibility, speculative feature
    side questOut-of-scope finding, deferred to its own issue
    on Oct 5, 2026
  2. changed the title [-]The task hash writes a queue_name field nobody reads[/-] [+]The task hash stores a queue_name field that no reader uses[/+] on Oct 5, 2026
  3. codingjoe commented on Oct 6, 2026

    @codingjoe
    OwnerAuthor

    Fixed on main by b55bee0, which this branch merged in 1296aa4. The enqueue mapping in RedisTaskBackend holds data and score only. No reader or writer uses a queue_name field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bloatOver-engineering and dead codeside questOut-of-scope finding, deferred to its own issueyeetDelete it: dead code, unused flexibility, speculative feature

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions