Skip to content

fix(hooks): post-edit-format discards dotnet format failures #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kig777 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(hooks): post-edit-format discards dotnet format failures #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dc95c4
fix(hooks): make post-edit-format actually format on Windows
kig777 Aug 8, 2026
28c8cfc
fix(hooks): report a failed dotnet format instead of discarding it
kig777 Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion hooks/post-edit-format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,28 @@ while [[ "$DIR" != "/" && "$DIR" != "." ]]; do
done

if [[ -n "$PROJECT" ]]; then
dotnet format "$PROJECT" --include "$FILE" --no-restore 2>/dev/null || true
# `dotnet format --include` takes paths relative to the current directory;
# an absolute path matches no file. The project argument in turn must be a
# native path — the C:/... form this script builds for the directory walk
# also makes --include match nothing. Either mistake formats nothing and
# still exits 0, which `2>/dev/null || true` then hides.
CWD=$(pwd)
if command -v cygpath >/dev/null 2>&1; then
# Git Bash: pwd is /c/..., while FILE was normalized above to C:/...
CWD=$(cygpath -m "$CWD" 2>/dev/null || echo "$CWD")
PROJECT=$(cygpath -w "$PROJECT" 2>/dev/null || echo "$PROJECT")
fi
INCLUDE="$FILE"
case "$FILE" in
"$CWD"/*) INCLUDE="${FILE#"$CWD"/}" ;;
esac
# Report a failed format instead of discarding it — that is what kept the
# path bug above invisible. Still exit 0: mid-edit files routinely fail to
# compile, and a hook that fails there would interrupt an ordinary edit.
if ! FORMAT_OUTPUT=$(dotnet format "$PROJECT" --include "$INCLUDE" --no-restore 2>&1); then
echo "post-edit-format: dotnet format failed for $INCLUDE (file left unformatted)"
echo "$FORMAT_OUTPUT"
fi
else
echo "No .csproj or .sln found for $FILE, skipping format"
fi