Repository navigation
Conversation
The footer preview at the bottom of /settings draws with the real footer renderer, but it passed the raw setting values in as chip text. With Startup mode set to Work the preview read "● ask agent" while the footer under the composer reads "● ask work", and with Plan it read "● ask plan" where the footer reads "● read only plan". Parse the two rows into AppMode and ApprovalMode and take the words and inks from the helpers the footer itself uses (mode_label, permission_label_for, header_mode_ink, header_permission_ink). The preview now also follows the UI language like the footer does. The 80x24 and 120x32 Settings goldens pinned "● ask agent" on the preview line; they now read "● ask work". Signed-off-by: Lstarsky0 <59827030+Lstarsky0@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
github-actions
Bot
added
the
contribution-gate
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The footer preview at the bottom of /settings draws with the real footer renderer, but it passed the raw setting values in as chip text, so it didn't match the footer it previews. At 80×24, before:
The footer under the composer says
● ask workfor the same mode. With Startup mode set to Plan the preview said● ask plan; the footer says● read only plan.After:
The preview now parses the two rows into
AppModeandApprovalModeand takes the words and inks from the helpers the footer itself uses (mode_label,permission_label_for,header_mode_ink,header_permission_ink), so it also follows the UI language. In zh-Hans with Plan it reads● 只读 plan, the same words the footer uses.Issue
Refs #6466
How I tested it
cargo fmt --all -- --check,cargo clippy -p codewhale-tui --all-targets --all-featureswith CI's flags, andcargo check -p codewhale-tui --all-targets: clean. Clippy also on 1.99, pluscargo +1.89.0 check -p codewhale-tui.cargo nextest run -p codewhale-tui --lib: 15326 passed, none failed.No new tests. The 80×24 and 120×32 Settings goldens (
config_panel_golden_at_eighty_and_one_twenty) pinned● ask agenton the preview line; that line now reads● ask work, nothing else in them changes.Checklist
maincargo fmt --allpasses, and tests cover new or changed behaviordocs/features.toml(cargo test -p codewhale-tui --test feature_registrychecks it) — n/a