Fix: center align down arrow in hero section - #2723
Conversation
|
@Pratith544 is attempting to deploy a commit to the Vivek Prajapati's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe Home page Hero section is restructured to a full-viewport layout (min-h-screen) with centered content; the DownArrow was moved out of the inline content into an absolutely positioned, bottom-centered overlay element with accessibility attributes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/User/pages/Home/Home.jsx`:
- Around line 246-248: The down-arrow is rendered as a non-focusable <div> and
never calls scrollToSection; replace the <div> wrapper with a focusable control
(e.g., a <button> element) around <DownArrow /> and wire its onClick to call
scrollToSection, add keyboard support by handling Enter/Space via onKeyDown (or
rely on button default behavior), and include an accessible label
(aria-label="Scroll to next section") so DownArrow is both clickable and
keyboard accessible; keep the existing className ("absolute bottom-6 left-1/2
transform -translate-x-1/2") and ensure the handler references the existing
scrollToSection function.
|
@codervivek5 Please assign to me.Myself OPEN SOURCE CONTRIBUTOR. |
|
Hi @codervivek5 It fixes the hero down-arrow alignment and adds scroll + accessibility improvements. Thanks for your time! |
|
This issue was raised by me. @Pratith544 should wait for assignment before submitting a PR. Kindly wait until the author assigns the issue. |
|
Thank you for pointing that out . |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This issus is raised by someone else so due to the policy I need to assign this to the first come person |
Fixes Issue
Closes #2722
Summary
This PR fixes the alignment of the down arrow in the homepage hero section.
Problem
The down arrow was previously placed inside the left content column, causing it to appear left-aligned instead of centered relative to the entire hero section.
Changes Made
relativeto support proper positioning.Result
The arrow is now properly centered across all screen sizes and behaves as a scroll indicator.
Screenshots
Summary by CodeRabbit