Skip to content

Merge Phase 1 follow-ups into master - #3

Closed
coderconnoisseur wants to merge 10 commits into
masterfrom
phase1-correctness
Closed

coderconnoisseur wants to merge 10 commits into
masterfrom
phase1-correctness

Conversation

@coderconnoisseur

Copy link
Copy Markdown
Owner

Brings the work from PR #2 (merged into `phase1-correctness` instead of `master`) into `master`:

  • env-var config for every service
  • `ride.unmatched` event from matching
  • assignment-service dedupe for `ride.matched`, `GET /rides/`, separate consumer group for `ride.unmatched`
  • epoch-stamped rewind-safe offset commits in `pkg/kafkaconsumer`
  • rider-simulator batched ticker

`master`'s only extra commit is the LICENSE (`29eb929`), so this PR also includes the merge of PR #1 already on `master`. Merge-tree check: no conflicts.

@coderconnoisseur

Copy link
Copy Markdown
Owner Author

Closing: this head would delete LICENSE from master. Reopened from a sync branch that merges origin/master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant