Repository navigation
fix(codex): respect CODEX_HOME - #1163
Merged
Merged
Conversation
35C4n0r
self-requested a review
October 1, 2026 17:22
35C4n0r
reviewed
Oct 1, 2026
35C4n0r
left a comment
35C4n0r
left a comment
Collaborator
There was a problem hiding this comment.
CODEX_HOME is a configuration variable; imho we should add a codex_home as a variable with "" (empty, so that we don't overwrite user's CODER_HOME) as the default, and a coder_env block which conditionally sets the CODEX_HOME env if var.codex_home != "".
@matifali @Edd88-pixel thoughts ?
Collaborator
|
@35C4n0r A codex_home input would be useful for convenience, but I’d keep it as a follow-up. CODEX_HOME can already be set through coder_agent.env or a separate coder_env; this PR fixes the module ignoring it |
Collaborator
|
@kdcokenny Have you tested this end-to-end with the Codex CLI to confirm it ? |
Contributor
Author
yep! |
35C4n0r
approved these changes
Oct 5, 2026
35C4n0r
added
version:patch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
respects
CODEX_HOMEwhen writingconfig.toml, falling back to$HOME/.codexwhen it's unset or empty.the module was always writing to
~/.codex, so Codex ignored the module's settings when using a custom config directory.Type of Change
Module Information
Path:
registry/coder-labs/modules/codexNew version:
v5.4.2Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)also i manually tested it to make sure that it failed as expected without this change and then passed as expected with the change.
Related Issues
Fixes #1157.