Repository navigation
feat(jfrog): add pnpm package manager support - #1078
Merged
Merged
Conversation
Edd88-pixel
marked this pull request as ready for review
August 26, 2026 12:26
matifali
approved these changes
Aug 27, 2026
Member
|
@Edd88-pixel has this been tested? Can we merge it? |
Collaborator
Author
|
yes it has already been tested you can merge |
Member
|
@codex review |
matifali
enabled auto-merge (squash)
September 23, 2026 13:51
3 of 4 tasks
matifali
added a commit
that referenced
this pull request
Oct 9, 2026
…on (#1168) ## Description `tag_release.sh` tagged every untagged module on the currently checked-out commit (HEAD). In a bulk release, where several modules merged since the last run, every tag pointed at the same commit, and that commit could include changes newer than the version being tagged. It now walks each module README's first-parent history, newest first, and tags the commit where the module block's `version` became the current value. With squash merges that is the PR's merge commit. The commit is resolved while scanning, so the "Tags to be created" list shows `tag -> sha` and `--dry-run` previews the real targets. The script never checks out anything (it tags by SHA), so the working tree and HEAD are unchanged after a bulk run. Notes: - Shallow clones can't be resolved reliably, so it warns and tags HEAD there. - A version that was reverted and re-bumped resolves to the latest bump. - A tag now contains the module as of its bump commit, not later changes made without a version bump. - `MAINTAINER.md` updated: no more checking out the merge commit first. ## Type of Change - [x] Bug fix ## Testing & Validation - [ ] Tests pass (`bun test`) (no tests cover this script) - [x] Code formatted (`bun fmt`) - [x] Changes tested locally: `--dry-run` over all modules, and the commit lookup against `jetbrains` (revert/re-bump), `jfrog-token`, `antigravity`, `vault-token` ## Real run Ran from this branch on macOS (after a dry run on macOS and on a Linux dogfood workspace, bash 5.3 / git 2.53, with matching output). It tagged the four pending modules, each on the commit that introduced its version. With the old script, all four would have pointed at HEAD (`f21e23b2`). | Tag | Tagged commit | Merge commit subject | On origin | | --- | --- | --- | --- | | `release/coder/agent-relay-claude-code/v0.2.0` | `84519820` | feat(agent-relay-claude-code): declare and expose the agent_relay_client_platform parameter (#1147) | yes | | `release/coder/aibridge-proxy/v1.0.1` | `6f894e74` | chore: AI Bridge -> AI Gateway rename (#1118) | yes | | `release/coder/jfrog-oauth/v1.4.0` | `f21e23b2` | feat(jfrog): add pnpm package manager support (#1078) | yes | | `release/coder/jfrog-token/v1.4.0` | `f21e23b2` | feat(jfrog): add pnpm package manager support (#1078) | yes | Pushed in two batches (3 + 1), 4 created, 0 failed. ## Related Issues None --- Generated with [Claude Code](https://claude.com/claude-code) using Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The JFrog token and OAuth modules can configure several package managers, but pnpm is not currently supported. Adding pnpm configuration lets workspaces resolve pnpm packages through Artifactory while preserving the existing npm configuration contract.
Closes #1074.
Changes
package_managers.pnpmrepository list to both JFrog modules.jf pnpmc --global --repo-resolveand generate the shared npm/pnpm.npmrccontent.~/.npmrc.1.3.0.Validation
bun test main.test.tsinjfrog-token: 12 tests passed, 35 assertions.terraform test -verboseinjfrog-oauth: 14 tests passed.terraform validatein both modules: passed.Type of Change
Module Information
Paths:
registry/coder/modules/jfrog-token,registry/coder/modules/jfrog-oauthNew version:
v1.3.0Breaking change: [ ] Yes [x] No
Testing & Validation
bun test)bun fmt)Related Issues
Closes #1074.