fix: keep mock tickers working until NewMock's cleanup by mafredri · Pull Request #38 · coder/quartz

fix: end ticker run loops when NewMock's cleanup runs

mafredri

committed

2cc289c

refactor(ticker.go): drop the per-ticker cleanup

mafredri

committed

c7d2613

test(mock_test.go): cover each way a ticker starts after its test

mafredri

committed

090f084

docs(mock.go): say when a mock ticker stops sending ticks

mafredri

committed

ed7f832

docs(ticker.go): say why fire also selects on done

mafredri

committed

5cf253f

test(mock_test.go): merge the after-test-end leak cases into a table

mafredri

committed

d4448ba

fix: stop ticker run loops through their interrupt channels

mafredri

committed

a3f86db

fix: send a tick to a waiting reader first

mafredri

committed

235137b

test(mock_test.go): cover a ticker read at NewMock's cleanup

mafredri

committed

9f9eae8

test(mock_test.go): read a fired ticker from a later cleanup

mafredri

committed

6e3d7b1

docs(ticker.go): wrap the Ticker channel comment to 100 columns

mafredri

committed

afdade2

docs(mock.go): say NewMock's cleanup also drops ticks

mafredri

committed

8ae4b6b

test(mock_test.go): say which send the rounds catch

mafredri

committed

c86466d

fix: send a tick after NewMock's cleanup to a waiting reader

mafredri

committed

26c4c34

fix: receive no stale tick after Ticker.Reset

mafredri

committed

e890a4e

test(mock_test.go): share the channel helpers and drop a redundant row

mafredri

committed

86484a1

docs: point NewTicker at NewMock and drop a wrong Stop comment

mafredri

committed

0eb9a1d

fix: panic on Ticker.Reset with a non-positive duration

mafredri

committed

1143133

docs(mock.go): say what NewMock's cleanup leaves of later fires

mafredri

committed

1dad7f8

fix: drop a held tick on Ticker.Reset without a new runLoop

mafredri

committed

1eea60c

docs(mock.go): name the timers and tickers NewMock's cleanup limits

mafredri

committed

68cabaf

test(mock_test.go): reset a ticker from a bubble that did not create it

mafredri

committed

487178a

docs(mock.go): lead the NewMock doc with when to call it

mafredri

committed

295fadb

docs(ticker.go): say that a stopped ticker's Reset still starts runLoop

mafredri

committed

36e05d6

test(mock_test.go): keep one case in TestTicker_ResetInBubble

mafredri

committed

81398ed

test(mock_test.go): drop Stop calls that NewMock's cleanup covers

mafredri

committed

fddb3d8

test(mock_test.go): put TestTickerReset_NonPositiveDuration last

mafredri

committed

ea4df23

docs(ticker.go): reword which Reset of a stopped ticker hangs

mafredri

committed

95527a4

Navigation Menu

Repository navigation

fix: keep mock tickers working until NewMock's cleanup - #38

fix: keep mock tickers working until NewMock's cleanup#38
mafredri wants to merge 28 commits into
mafredri/timer-fire-cleanupfrom
mafredri/ticker-reset-leak

Commits on Nov 4, 2026

fix: end ticker run loops when NewMock's cleanup runs

refactor(ticker.go): drop the per-ticker cleanup

test(mock_test.go): cover each way a ticker starts after its test

docs(mock.go): say when a mock ticker stops sending ticks

docs(ticker.go): say why fire also selects on done

test(mock_test.go): merge the after-test-end leak cases into a table

fix: stop ticker run loops through their interrupt channels

fix: send a tick to a waiting reader first

test(mock_test.go): cover a ticker read at NewMock's cleanup

test(mock_test.go): read a fired ticker from a later cleanup

docs(ticker.go): wrap the Ticker channel comment to 100 columns

docs(mock.go): say NewMock's cleanup also drops ticks

test(mock_test.go): say which send the rounds catch

fix: send a tick after NewMock's cleanup to a waiting reader

fix: receive no stale tick after Ticker.Reset

test(mock_test.go): share the channel helpers and drop a redundant row

docs: point NewTicker at NewMock and drop a wrong Stop comment

fix: panic on Ticker.Reset with a non-positive duration

docs(mock.go): say what NewMock's cleanup leaves of later fires

fix: drop a held tick on Ticker.Reset without a new runLoop

docs(mock.go): name the timers and tickers NewMock's cleanup limits

test(mock_test.go): reset a ticker from a bubble that did not create it

docs(mock.go): lead the NewMock doc with when to call it

docs(ticker.go): say that a stopped ticker's Reset still starts runLoop

test(mock_test.go): keep one case in TestTicker_ResetInBubble

test(mock_test.go): drop Stop calls that NewMock's cleanup covers

test(mock_test.go): put TestTickerReset_NonPositiveDuration last

docs(ticker.go): reword which Reset of a stopped ticker hangs