Repository navigation
release: publish to and upgrade from coder/llm-helper - #56
Merged
Merged
Conversation
The repository was renamed, and coder/vllm-helper now only redirects. Reads follow the redirect, but GoReleaser creates the release and uploads its archives under the configured name, and that has not been tried through a redirect. Name the repository it is now. upgrade asks the new name too. Builds from before this still ask for coder/vllm-helper and keep finding releases through the redirect.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the updates directing release publishing and upgrade checks to the canonical coder/llm-helper repository.
No open issues 🎉
What changed in this PR
Updates release publishing and upgrade checks to use the canonical coder/llm-helper repository instead of relying on the old repository’s redirect.
Changes:
- Points GoReleaser publishing directly at
coder/llm-helper. - Updates the upgrade source and documents redirect compatibility for older builds.
| File | Description |
|---|---|
internal/update/update.go |
Changes the release source to coder/llm-helper and explains older-build compatibility. |
.goreleaser.yaml |
Sets the release destination to the renamed repository. |
Review effort: Balanced
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository is now coder/llm-helper, and coder/vllm-helper only redirects to it. Two places still used the old name.
.goreleaser.yaml:release.github.namewasvllm-helper, so tagging would create the release and upload its archives through the redirect. Reads work through it; creating a release and uploading through it has not been tried, and a failure would leave a pushed tag with no release. It now namesllm-helper.internal/update:upgradenow askscoder/llm-helper. Installed builds from before this still ask forcoder/vllm-helperand keep finding releases through the redirect.No CHANGELOG entry, since nothing changes for users.
Checks
go vet ./...andgo test -race ./internal/update/ ./internal/cli/,gofmt, prettier.upgrade --checkon the stable channel (found v0.5.0) and on the dev channel (founddevat f6aadf6).coder/vllm-helper, finds the same releases through the redirect.