fix(api): skip the page audit tests when playwright-core is missing - #154
Merged
Merged
Conversation
PageAudit::available() only checked for node and the script file. On a
machine with node but without tools/node_modules (every fresh worktree)
the tests ran, qa-page.cjs died on require('playwright-core') and eleven
PageAuditTest cases failed with an empty report instead of skipping.
available() now also requires playwright-core beside the script, which
is where the API image and CI install it. The test docblock no longer
claims CI skips these tests (CI installs the driver and runs them) and
the skip message names the npm command that fixes it.
Project: Appwerk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a machine with node but without
apps/api/tools/node_modules(every fresh worktree),PageAudit::available()returned true,qa-page.cjsdied onrequire('playwright-core')and 11PageAuditTestcases failed instead of skipping.PageAudit::available()also requirestools/node_modules/playwright-core, where the API image and CI install it. It is only called by the tests, so production is unaffected.PageAuditTestdocblock no longer says CI skips these tests: CI installs the driver and runs them. The skip message namesnpm --prefix tools ci.Checked locally:
tools/node_modules: PageAuditTest 12/12 passedProject: Appwerk