fix(web): phone polish after the mobile check of every page - #151
Merged
Merged
Conversation
A pass over every page at 375px and 360px found no sideways overflow, and these smaller problems: - Home, "your own idea" and "who builds this": the grey lines were inline <small> text inside a block with a 26px line height, so a 13px line got double spacing. They are blocks with their own line height. - Project page: the arrow of "Start Care for 9 €/month →" fell onto a line of its own; a non-breaking space keeps it with the price. - Text links were 18 to 25px tall, below a finger's size. On touch screens "Try it for free", "All app ideas", "Sign out", the history's "Remove" and the project downloads get a 40px hit area; the mouse layout does not change. Project: Appwerk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mobile audit of every page at 375 and 360 px (live, signed in as developerweb for the account pages): no sideways overflow anywhere. Fixes for what it did find:
<small>lines in the own-idea box and the about chips had double line spacing; now blocks with their own line height.pointer: coarse): small text links get a 40px hit area.Checked locally with a touch-emulated 375px viewport. tsc passes.