Skip to content

Lab shannon - #11

Open
sedillon93 wants to merge 14 commits into
codefellows-seattle-javascript-401d19:masterfrom
sedillon93:lab-shannon
Open

sedillon93 wants to merge 14 commits into
codefellows-seattle-javascript-401d19:masterfrom
sedillon93:lab-shannon

Conversation

@sedillon93

Copy link
Copy Markdown

No description provided.

Comment thread .eslintignore Outdated
@@ -0,0 +1,7 @@
# Created by Vinicio Vladimir Sanchez Trejo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 1-2 should be deleted

Comment thread .eslintrc Outdated
@@ -0,0 +1,28 @@
# Created by Vinicio Vladimir Sanchez Trejo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 1-2 need to be deleted

Comment thread README.md
* Add or Mutiply a Hue
* Add or Subtract Contrast

The program alters an image (bmp format) using one of three provided transformation types and saves the new image as a different file. Three parameters are required: the file path of the image to be altered (must be a .bmp format), the desired output file path (with .bmp extension), and the name of the transform desired (invert, randomize, or greyscale). If a parameter is not supplied the program will return an error. If the transformation type is not one of the three provided an error will be thrown and no new image will be created.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of your files ending in .md should use proper markdown syntax. this is a big project, be a bit more specific :)

const bitmapTransformer = require(`../lib/bitmapTransformer`);
const indexJS = require(`../index.js`);

describe(`bitmapTransformer.js`, () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test suite won't run at all

Comment thread index.js Outdated
@@ -0,0 +1,46 @@
#!/usr/bin/env node

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lines 1-2 need to be deleted

…f arguments provided to bitmaptransformer.readfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants