fix(graphql): make components field arguments optional with defaults - #2173
fix(graphql): make components field arguments optional with defaults#2173sentry[bot] wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
==========================================
- Coverage 91.63% 91.62% -0.01%
==========================================
Files 1337 1337
Lines 53262 53268 +6
Branches 1647 1647
==========================================
+ Hits 48805 48808 +3
- Misses 4136 4139 +3
Partials 321 321
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
Seer wants to keep iterating on this pull request to get CI passing, but the Sentry GitHub App installation is missing permissions it needs to read the failing checks and push a fix. Review and accept the updated permissions to let Seer continue: https://github.com/organizations/codecov/settings/installations/86101127/permissions/update |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (57.14%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This PR addresses
GraphQLErrors occurring when thecomponentsfield in theCoverageAnalyticsGraphQL type is queried without providing theafter,before, andintervalarguments. Previously, these arguments were marked as non-nullable (!) in the schema, causing validation errors for clients that omitted them.Changes Made:
apps/codecov-api/graphql_api/types/coverage_analytics/coverage_analytics.graphqlto remove the non-null (!) constraint frominterval,before, andafterarguments on thecomponentsfield, making them optional.resolve_components_measurementsresolver inapps/codecov-api/graphql_api/types/coverage_analytics/coverage_analytics.pyto handleNonevalues for these arguments.intervalnow defaults toInterval.INTERVAL_30_DAYif not provided.beforenow defaults to the current datetime if not provided.afternow defaults tobefore - (interval.value * 3) daysif not provided, providing a sensible default time range (e.g., 90 days for a 30-day interval).This change ensures that clients can query the
componentsfield without explicitly providing these temporal arguments, improving API usability and preventing common errors. It resolves issues API-EZS, API-EZT, API-EZV, and API-CDS.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EZS
This PR was automatically generated by Sentry. You can adjust this setting at any time.