Skip to content

fix(worker-jacoco): handle missing 'nr' attribute in JaCoCo reports - #2171

Open
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/jacoco-missing-nr
Open

fix(worker-jacoco): handle missing 'nr' attribute in JaCoCo reports#2171
sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/jacoco-missing-nr

Conversation

@sentry

@sentry sentry Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

This PR addresses a KeyError: 'nr' occurring in apps/worker/services/report/languages/jacoco.py when processing JaCoCo XML reports. The error happened because the code directly accessed attr["nr"] on XML line elements, which would crash if the 'nr' attribute was absent.

The fix replaces attr["nr"] with attr.get("nr", 0). This change ensures that if the 'nr' attribute is missing, ln defaults to 0. The existing if ln > 0: guard then correctly routes these malformed lines to a warning log and skips their processing, preventing the KeyError and improving the robustness of JaCoCo report parsing. This issue has recurred previously, so ensuring this fix is deployed is crucial.

Legal Boilerplate

Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.

Fixes WORKER-YPX

This PR was automatically generated by Sentry. You can adjust this setting at any time.

@thomasrockhu-codecov

Copy link
Copy Markdown
Contributor
✨ Harness AI Code Review View in Harness →

ℹ️ Review in progress — analyzing the changes on this pull request.
This comment updates automatically when the review finishes.

@codecov-notifications

codecov-notifications Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (17e0f08) to head (68787d5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2171   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files        1337     1337           
  Lines       53262    53262           
  Branches     1647     1647           
=======================================
  Hits        48805    48805           
  Misses       4136     4136           
  Partials      321      321           
Flag Coverage Δ
workerintegration 58.49% <0.00%> (ø)
workerunit 90.55% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant