Skip to content

fix(graphql): prevent client validation errors from Sentry logging #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −6
Open

fix(graphql): prevent client validation errors from Sentry logging #2168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions apps/codecov-api/graphql_api/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,17 +342,16 @@ def context_value(self, request: WSGIRequest, *_args: Any) -> dict[str, Any]:
}

def error_formatter(self, error: Any, debug: bool = False) -> dict[str, Any]:
user = self.request.user
is_anonymous = user.is_anonymous if user else True
# the only way to check for a malformed query
is_bad_query = "Cannot query field" in error.formatted["message"]
if debug or (not is_anonymous and is_bad_query):
original_error = error.original_error
# GraphQL validation/syntax errors have no original_error — they are
# client query errors (bad field names, invalid fragment spreads, etc.)
# and should never be reported to Sentry as internal server errors.
if debug or original_error is None:
return format_error(error, debug)
formatted = error.formatted
formatted["message"] = "INTERNAL SERVER ERROR"
formatted["type"] = "ServerError"
# if this is one of our own command exception, we can tell a bit more
original_error = error.original_error
if isinstance(original_error, BaseException) or isinstance(
original_error, ServiceException
):
Expand Down
Loading