fix(graphql_api): handle invalid GraphQL queries gracefully - #2162
Open
sentry[bot] wants to merge 1 commit into
Open
fix(graphql_api): handle invalid GraphQL queries gracefully#2162sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
GraphQLErrors caused by invalid client queries (e.g., requesting a non-existent field) were treated as unhandled internal server errors, particularly for anonymous users. This led to these client-side validation errors being logged at anerrorlevel and captured by Sentry.This change modifies the
error_formatterinAsyncGraphqlViewto correctly identify and handleis_bad_queryscenarios. Now, such errors will always result in a standard GraphQL error response being returned to the client, regardless of the user's authentication status. Additionally, these events are now logged at awarninglevel, and Sentry will no longer capture them as unhandled exceptions, reducing noise from non-actionable client errors.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EZG
This PR was automatically generated by Sentry. You can adjust this setting at any time.