fix(graphql): prevent client schema errors from Sentry reporting - #2159
Open
sentry[bot] wants to merge 1 commit into
Open
fix(graphql): prevent client schema errors from Sentry reporting#2159sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, GraphQL schema validation errors (e.g., a client querying a non-existent field like 'foo' on 'TestResult') were being logged as 'GraphQL internal server error' and captured by Sentry. This was incorrect, as these are client-side mistakes, not server-side bugs.
This change modifies the
error_formatteringraphql_api/views.pyto specifically handle these client-side schema validation errors. For anonymous users, if the error message indicates a 'Cannot query field' issue, a genericINVALID_QUERYerror is returned to the client, and the error is no longer logged to Sentry. This reduces Sentry noise and correctly classifies the error type, while preserving the security boundary of not exposing specific field names to anonymous users for invalid queries.Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EZF
This PR was automatically generated by Sentry. You can adjust this setting at any time.