fix(graphql): handle malformed queries with extra quotes - #2158
Open
sentry[bot] wants to merge 1 commit into
Open
fix(graphql): handle malformed queries with extra quotes#2158sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
GraphQLSyntaxErrorthat occurred when clients sent GraphQL queries with the entire query string wrapped in an additional layer of double-quotes within the JSON body. This caused the lexer to misinterpret parts of the query (e.g.,1024XEngineer) as invalid numbers after prematurely closing a string literal.Changes Made:
get_clean_querymodification: Theget_clean_querymethod inapps/codecov-api/graphql_api/views.pyhas been updated to detect and strip any extraneous surrounding double-quotes from the GraphQL query string. This ensures that the query passed for further processing is correctly formatted.postmethod update: Thepostmethod now rewritesrequest._bodywith the normalized query string. This is crucial because theariadneparser, which is called by the parentGraphQLAsyncView, reads directly fromrequest.body. By updatingrequest._body, we ensure that the parser receives the corrected, unquoted query, preventing theGraphQLSyntaxError.This fix improves the robustness of the GraphQL API against malformed client requests, specifically those that incorrectly double-quote the query field in the JSON payload.
Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes API-EZE
This PR was automatically generated by Sentry. You can adjust this setting at any time.