Skip to content

ci: ban lint allow escape hatches - #151

Merged
codeandsolder-git-wrangler[bot] merged 1 commit into
mainfrom
policy/no-handwritten-allow
Oct 30, 2026
Merged

codeandsolder-git-wrangler[bot] merged 1 commit into
mainfrom
policy/no-handwritten-allow

Conversation

@codeandsolder-git-wrangler

Copy link
Copy Markdown

Summary

  • make non-CI Python forbidden by default at workflow, composite-action, and direct-script layers
  • reject handwritten #[allow], Cargo lint levels set to allow, and Rust -A/--allow flags
  • keep narrow reasoned #[expect] as the handwritten suppression mechanism, including real configuration-scoped cfg_attr(..., expect(...))
  • add negative fixtures for source, Cargo-manifest, and rustflags escape hatches
  • document immutable reusable-workflow pins as @<full-sha> # main so Renovate can advance them without floating execution

Validation

  • uv run --no-project python checks/test_source_lint_policy.py — 7/7
  • central Ruff + format + ty on checker/tests — green
  • focused strict gate fixtures: reasoned expect passes; reasoned allow/Cargo allow/-A all reject
  • Python location default reject + explicit opt-out both verified
  • RUSTC_WRAPPER=sccache bash checks/check.sh — full 325-rule corpus and runtime contracts green
  • git diff --check

@coderabbitai

coderabbitai Bot commented Oct 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cc755e8e-3f7d-49f3-9023-df1c87c71bbd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeandsolder-git-wrangler
codeandsolder-git-wrangler Bot merged commit 260a48d into main Oct 30, 2026
5 checks passed
@codeandsolder-git-wrangler
codeandsolder-git-wrangler Bot deleted the policy/no-handwritten-allow branch October 30, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant