chore(contract): sync flipcash2 protos to 0b56e3cd - #7
Merged
Conversation
Adds message_edit_window and message_delete_window to UserFlags as optional google.protobuf.Duration fields at 17 and 18. Purely additive -- no existing field or enum case moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs to
flipcash2-protobuf-api@0b56e3cd— "Add message_{edit,delete}_window to UserFlags (#89)", one commit ahead of the previous pin0300d252.Contract change
proto/account/v1/flipcash_account_service.protois the only proto that moved (+6/-0). Two fields appended tomessage UserFlags:google.protobuf.Duration message_edit_window = 17— the window after a message is created during which it can still be editedgoogle.protobuf.Duration message_delete_window = 18— the same, for deletionNothing else changed. No services, RPCs, or messages were added, removed, or reshaped, no result enum gained or reordered a case, and nothing was renumbered:
username_min_balancekeeps field 16 and every field before it keeps its number.Both fields are message-typed, so they carry explicit presence. An unset value is not a zero-length window, and the changelog entry tells consumers to check
hasMessageEditWindow/hasMessageDeleteWindowbefore reading either one.Generated Swift moved only in
account_v1_flipcash_account_service.pb.swift(+36 lines): the two accessors, their presence checks andclearmethods, the storage fields, the name-map entries, and the decode/traverse/equality cases for 17 and 18.scripts/toolchain.envis untouched, so none of that churn is toolchain drift.Release
Targets
0.4.0, which is not yet tagged. The matchingCHANGELOG.mdsection is in this branch, sopublish.ymlhas release notes to extract.Consumers
Both app PRs are drafts. They pin
0.4.0, which does not exist until this merges andpublish.ymlruns, so neither can go green before then — app CI never sees the local override that both were developed against.