fix(deps): resolve shared-core at the 0.7.1 that carries ReportReason - #827
Merged
Merged
Conversation
main does not build from its committed pins. `AllTargets` fails with `cannot find type 'ReportReason' in scope`, and testing is cancelled before a single test runs. #821 added the report flow against `SharedCoreKit.ReportReason` and developed it through the `FLIPCASH_SHARED_CORE_LOCAL` path dependency that the same PR introduced. `Package.resolved` was correctly restored to the pinned 0.7.0 before committing, as that manifest's comment instructs, but the shared-core release carrying the type was never cut, so nothing published provided it. shared-core 0.7.1 publishes it. `.upToNextMinor(from: "0.7.0")` already admits 0.7.1, so only the resolved pin moves and the three manifests consuming SharedCoreKit stay untouched. The same file also still pinned flipcash2-client-protocol at 0.10.0. `FlipcashAPI/Package.swift` requires the contract packages `exact:`, and #824 moved that declaration to 0.11.0 without committing the resolution it forces, so every build since has rewritten the file locally. Commit that too rather than leave the checked-in state unbuildable as written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maindoes not build from its committed pins.AllTargetsfails withcannot find type 'ReportReason' in scopeand cancels testing before a single test runs.#821 added the report flow against
SharedCoreKit.ReportReasonand developed it through theFLIPCASH_SHARED_CORE_LOCALpath dependency that the same PR introduced.Package.resolvedwas correctly restored to the pinned 0.7.0 before committing, as that manifest's comment instructs — but the shared-core release carrying the type was never cut, so nothing published provided it. The Kotlin side has been oncode/cashsince code-android-app#1519.shared-core 0.7.1 now publishes it.
.upToNextMinor(from: "0.7.0")already admits 0.7.1, so only the resolved pin moves and the three manifests consumingSharedCoreKitstay untouched.The second pin in this diff
The same file still pinned
flipcash2-client-protocolat 0.10.0.FlipcashAPI/Package.swiftrequires the contract packagesexact:, and #824 moved that declaration to 0.11.0 without committing the resolution it forces, so every build since has rewritten the file locally and left it dirty. It never broke anything visibly, which is why it went unnoticed. Same class as #778 and #786.Note for whoever hits this next
xcodebuild -resolvePackageDependencieswill not upgrade past an existing pin, and SwiftPM's cached clones — both~/Library/Caches/org.swift.swiftpm/repositories/and the DerivedDataSourcePackages/repositories/copy — do not learn about a new tag on their own. Both had to be purged for that package before 0.7.1 was visible.