fix(chat): give the reply's close button its own ground - #732
Merged
Conversation
The quote above the composer is now Liquid Glass sampling the transcript, so the dismiss control's contrast moved with whatever message scrolled behind it. A hairline ✕ at `.light` in `textSecondary` was the least dense thing on the bar and had the least to spare. Draw it as `xmark.circle.fill` instead. The disc is a plain translucent fill, not a second glass layer — glass nested in glass muddies the layering, and on a glass platter controls are meant to be drawn on it rather than above it. Palette rendering rather than monochrome, because a monochrome fill knocks the ✕ out as a hole that the transcript then shows through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #730, which made the reply quote Liquid Glass over the transcript. That change moved the ground under the quote's dismiss control from an opaque slab to glass sampling whatever is behind it, and the control was still drawn for the slab: an 18pt
.lightxmarkintextSecondary, the least dense thing on the bar. Its contrast now varied with which message had scrolled past.Drawn as
xmark.circle.fillinstead, so the glyph carries its own ground.The disc is a plain translucent fill (
textSecondaryat 35%), not a second glass layer. Nesting glass in glass muddies the layering; a control on a glass platter belongs on it, not above it.CancelEditButtonin the same bar does get its ownglassBackground, and that stays correct — the bar's surface under it is opaquebackgroundMain, so that is one glass level rather than two.Palette rendering rather than monochrome: a monochrome fill knocks the ✕ out as a transparent hole, which over glass fills with the transcript — the exact thing the disc is there to prevent.
SystemSymbolgainscloseCircleso the strip keeps using the app's symbol vocabulary rather than a raw string.closeis untouched and still used byCancelEditButton.Both candidates were built and compared on device before picking this one; the alternative was matching
CancelEditButton's 17pt semiboldxmarkintextMain.